Look through definitions to find an operation type #42
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
There were the following issues with this Pull Request
You may need to change the commit messages to comply with the repository contributing guidelines. 🤖 This comment was generated by commitlint[bot]. Please report issues here. Happy coding! |
amcvitty
force-pushed
the
no-undefined-operation-types
branch
2 times, most recently
from
f317dca to
fb64a8f
Compare
Previously we were just reporting the first, which for large queries was often a fragment definition, which doesn't have an operation. In most use cases, there will be exactly one query or mutation. In the case where there are multiple, we'll report one of them (no worse than before!). Also - correct spelling of "elapsed"
amcvitty
force-pushed
the
no-undefined-operation-types
branch
from
fb64a8f to
16aff60
Compare
|
Hi - I just checked back on this because I'm still a bit frustrated by the Any feedback on this PR? Can a maintainer help me understand what more I would need to do to get this merged? Please note that I've already corrected the issues identified by commitlint. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why
It's weird that often the link logs with undefined type
What:
For documents with queries and fragment definitions, often I was noticing that the operation type was reported as undefined.
The root cause is that we were looking at the first definition in the query, which in our app is often a Fragment Definition instead of an Operation Definition and so doesn't have an operationType (query/mutation etc).
So instead since most documents have a single operation, I'm trying to find and report its operationType instead of looking only at the first definition.
How:
This change simply looks through to find one that isn't undefined. It's still picking one from an array, but I think this is generally going to give better results than the previous heuristic of taking the first.
Checklist: