ci: pin every action reference to a commit SHA - #178
Open
singlerider wants to merge 1 commit into
Open
singlerider wants to merge 1 commit into
singlerider wants to merge 1 commit into
Conversation
A tag is a mutable pointer the upstream owner can move, and whatever bytes it resolves to run with the workflow token. Every `uses:` now names a full 40-character commit SHA, with the tag kept as a trailing comment so Dependabot can still read the version and bump the pin. This also removes the last floating references: `@stable`, `@latest`, `@main` on our own CLA reusable workflow, and the two `release/v1*` branches on the PyPI publish path. Runners move from ubuntu-latest to ubuntu-24.04 for the same reason. A floating runner label is an unfixed input like any other. Refs #149
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Every
uses:reference in this repository is now pinned to a full40-character commit SHA, with the tag preserved as a trailing comment.
runs-on: ubuntu-latestbecomesubuntu-24.04.Why
A tag is a mutable pointer the upstream owner can move, and whatever
bytes it resolves to run with this workflow's token. The same applies to
a floating runner label. Pinning submodules and image digests elsewhere
in the family while CI's own code floats leaves that work decorative.
The tag stays on as a trailing comment so Dependabot can still read the
version and bump the pin in place. The
github-actionsecosystem isalready enabled here, so the pins stay maintained without extra process.
Floating references removed
Across the family this pass also removes
@stable(dtolnay/rust-toolchain),@latest(medyagh/setup-minikube),@mainon our own CLA reusableworkflow, and both
release/v1*branches on the PyPI publish path.Validation
uses:in this repo resolves to a 40-character SHAubuntu-latestremainsdereferenced to their target commit
Commented-out references were deliberately left alone.
Refs #149