Gh work #34
Closed
Gh work #34
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Bump the version in cloudinit/version.py to 25.1.3 and update ChangeLog.
Bump the version in cloudinit/version.py to 25.1.4 and update ChangeLog.
Signed-off-by: Thomas Boerger <[email protected]>
Corrects the spelling of the fstab 'fs_freq' field from 'fs-freq' to 'fs_freq' in documentation, examples, and comments. Fixes canonicalGH-6210
…ical#6200) Recently the Landscape server started tracking the status of commands delivered to clients that run on parent instances, notably the Ubuntu Pro for WSL agent, by assigning request IDs which the pro agent refers to when replying with the command completion status. For the case of the Install command, which results in a new WSL instance being created on the parent Windows machine and registered with Landscape, the server also expects the same value to be part of the landscape-client registration message. For that we need the `installation_request_id` to be added to the client.conf file. We found that synergic to the concept of `metadata.instance-id`, thus this refactoring in the WSL datasource aims to allow: - the pro agent to write a per-instance metadata file - the WSL data source to use the `metadata.instance-id` as `installation_request_id` - if the landscape.client config exists - if doesn't contain that field. Details were discussed in the specification document WS042 - Handle Landscape request_id in command Install via cloud-init
CentOS is using the same PKI paths as RHEL. Signed-off-by: Kees Bakker <[email protected]>
Signed-off-by: Mostafa Abdelwahab <[email protected]>
Move it to tests/unittests/conftets.py and substitute MockPaths with it.
mtu: 0 is an invalid value within neptlan configuration, but cloud-init allowed it in previous releases. Since this also applies to v2 passthrough, we need strip the line outside of normal parsing. This commit adds a flag to allow cloud-init to strip it from downstreams to keep backwards compatibility. Fixes canonicalGH-6239
Highlight that the network device table printed to the terminal during boot is intended to be debug-level output rather than user-level information. Explain potential justifications for unexpected output and reference the debugging docs as a method of further investigation. Fixes: canonicalGH-6161
The description includes `both base config and meta config`, but those terms aren't defined in the page, and can be thought to refer to the base config and meta-data configuration formats rather than user-data. Since the description already says "any kind of user-data format", just remove the clarification.
Move it to tests.unitests.helpers, make it public and prepare for use in other tests cases.
Also, refactor clouds.py to make pyright typing happier
The existing reaper implementation was created as a session singleton. This worked but had a few problems: * Requires use of several global variables * Makes use of less documented pytest hooks * Meant that a test session cannot be started without initializing the session_cloud fixture. This can be a fairly long process that shouldn't be run unless necessary * It made it harder to reason about the pytest setup process when both fixtures and custom hooks are involved For these reasons, and to hopefully make an xdist implementation easier, the reaper was converted to be a fixture.
Now we finally can remove this one fully and forever. Fixes canonicalGH-5760
Signed-off-by: Mostafa Abdelwahab <[email protected]>
Signed-off-by: Mostafa Abdelwahab <[email protected]>
Signed-off-by: Mostafa Abdelwahab <[email protected]>
blackboxsw
force-pushed
the
gh-work
branch
7 times, most recently
from
f76d9f4 to
e84d994
Compare
|
Hello! Thank you for this proposed change to cloud-init. This pull request is now marked as stale as it has not seen any activity in 14 days. If no activity occurs within the next 7 days, this pull request will automatically close. If you are waiting for code review and you are seeing this message, apologies! Please reply, tagging TheRealFalcon, and he will ensure that someone takes a look soon. (If the pull request is closed and you would like to continue working on it, please do tag TheRealFalcon to reopen it.) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
20 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed Commit Message
Additional Context
Test Steps
Merge type