Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated mssclient.py to Python3. #3

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

0xdf-0xdf
Copy link

With python2 largely going away, and things like pip2 and python setup tools are difficult to find and install. Even just getting impacket as Python2 onto a new VM is challenging.

Updated to Python3 required small changes.

  • byte strings where needed
  • import _thread instread of thread
  • replaced encode.('hex') with hex()

Also moved listening message to where listening
actually happens. On slow machines, can give the
impression that it is listening before it is.

Changes to be committed:
modified: mssqlclient.py

Updated to Python3:
  - byte strings where needed
  - import _thread instread of thread
  - replaced `encode.('hex')` with `hex()`

Also moved listening message to where listening
actually happens. On slow machines, can give the
impression that it is listening before it is.

Changes to be committed:
	modified:   mssqlclient.py
@xassiz
Copy link
Member

xassiz commented Feb 22, 2021

Hey! We've thought about a Python3 release but keeping Python2 compatibility as well, like other Impacket examples do.

We are open for a new pull request if you want to. Thank you!

@ToBeatElite
Copy link

The upload and download features you've came up with are awesome, and 0xdf has already ported it to python3. I feel like putting that code to the main impacket mssqlclient.py could be epic so it's there by default for everyone. is there some objection against doing this bc this repo is years old and it should not be too hard to integrate it into the impacket repo? i dont intent to sound like "Why don't u push your code to the main repo", im just genuinely curious since im sure these functions would be helpful

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants