Skip to content

[WIP] fix: Add overwrite option to uploadToEntity method#330

Merged
dswbx merged 4 commits intobknd-io:mainfrom
jonaspm:fix/upload-media-entity-overwrite
Jan 9, 2026
Merged

[WIP] fix: Add overwrite option to uploadToEntity method#330
dswbx merged 4 commits intobknd-io:mainfrom
jonaspm:fix/upload-media-entity-overwrite

Conversation

@jonaspm
Copy link
Contributor

@jonaspm jonaspm commented Jan 8, 2026

Fixes #329

@cameronapak
Copy link
Collaborator

@jonaspm Dude, thank you for doing this!

question: have you tested this? Does it work?

@jonaspm
Copy link
Contributor Author

jonaspm commented Jan 8, 2026

currently under testing, will report back :D

@dswbx dswbx changed the base branch from main to release/0.20 January 9, 2026 10:28
@dswbx
Copy link
Contributor

dswbx commented Jan 9, 2026

@jonaspm thanks a lot for adding this! I added some tests to ensure it's respected, need to test it also later client side. I've changed the base to the 0.20 release branch, as there were quite some changes (don't mind the additional diffs added)

@jonaspm jonaspm changed the title fix: Add overwrite option to uploadToEntity method [WIP] fix: Add overwrite option to uploadToEntity method Jan 9, 2026
@dswbx dswbx deleted the branch bknd-io:main January 9, 2026 13:32
@dswbx dswbx closed this Jan 9, 2026
@dswbx dswbx reopened this Jan 9, 2026
@dswbx dswbx changed the base branch from release/0.20 to main January 9, 2026 13:33
@dswbx dswbx merged commit 047bb80 into bknd-io:main Jan 9, 2026
2 checks passed
@jonaspm jonaspm deleted the fix/upload-media-entity-overwrite branch January 9, 2026 15:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

media.uploadToEntity() lacks overwrite option.

3 participants