Fix: Fix Uniform buffer doing too many iterations when updating renderer uniforms #3372
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When rendering 1275 drawcalls with heavy uniform use without discarding textures and uniforms, I was having terrible performance, worse than when discarding.
While investigating, I realized that when BGFX calls
rendererUpdateUniforms
, it always had_begin
set to 0.I looked at how
EncoderImpl::dispatch
always sets them_uniformBegin
tom_uniformEnd
after each item is added, so I did the same forEncoderImpl::submit
, and the issue is fixed! I actually have much better performance than when using discards, which is to be expected!As requested, I tested the examples and they seem to work fine, so I believe there should be no side effects!