-
Notifications
You must be signed in to change notification settings - Fork 1.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Skip uniform names that contain .@data.
#3155
base: master
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This should be fixed on shaderc side to now allow .@data.
to be treated as uniform.
.
.@data.
Done. |
Is this consistent behavior with D3D11? |
I have no idea, I found no such check there to begin with. |
I mean if you compile with D3D compiler you get exactly the same uniform name that you get with SPIRV after trimming |
c248aaf
to
f16ad4a
Compare
5df4dd1
to
897d714
Compare
In some instances where one would have a structured buffer such as:
Then the uniform name generated would be:
This would fail the uniform name validation check, because of the
.@data.
in the name.