Skip to content

Conversation

@enmande
Copy link
Contributor

@enmande enmande commented Oct 17, 2025

🎟️ Tracking

PM-24621

📔 Objective

Add a test suite for the ProfileService.

📸 Screenshots

N/A

⏰ Reminders before review

  • Contributor guidelines followed
  • All formatters and local linters executed and passed
  • Written new unit and / or integration tests where applicable
  • Protected functional changes with optionality (feature flags)
  • Used internationalization (i18n) for all UI strings
  • CI builds passed
  • Communicated to DevOps any deployment requirements
  • Updated any necessary documentation (Confluence, contributing docs) or informed the documentation team

🦮 Reviewer guidelines

  • 👍 (:+1:) or similar for great changes
  • 📝 (:memo:) or ℹ️ (:information_source:) for notes or general info
  • ❓ (:question:) for questions
  • 🤔 (:thinking:) or 💭 (:thought_balloon:) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion
  • 🎨 (:art:) for suggestions / improvements
  • ❌ (:x:) or ⚠️ (:warning:) for more significant problems or concerns needing attention
  • 🌱 (:seedling:) or ♻️ (:recycle:) for future improvements or indications of technical debt
  • ⛏ (:pick:) for minor or nitpick changes

@codecov
Copy link

codecov bot commented Oct 17, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 50.73%. Comparing base (449603d) to head (588aa98).
⚠️ Report is 9 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #6466      +/-   ##
==========================================
- Coverage   54.83%   50.73%   -4.11%     
==========================================
  Files        1866     1869       +3     
  Lines       82751    82798      +47     
  Branches     7321     7322       +1     
==========================================
- Hits        45379    42005    -3374     
- Misses      35692    39191    +3499     
+ Partials     1680     1602      -78     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@github-actions
Copy link
Contributor

github-actions bot commented Oct 17, 2025

Logo
Checkmarx One – Scan Summary & Detailsd8522efe-7352-4759-9df9-a42069201c37

Great job! No new security vulnerabilities introduced in this pull request

@enmande enmande marked this pull request as ready for review October 17, 2025 19:44
@enmande enmande assigned enmande and unassigned enmande Oct 17, 2025
@enmande enmande requested review from a team and JaredSnider-Bitwarden October 17, 2025 19:46
Copy link
Contributor

@ike-kottlowski ike-kottlowski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Excellent work with test comments, thank you.

Copy link
Contributor

@JaredSnider-Bitwarden JaredSnider-Bitwarden left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Excellent work!

@enmande enmande merged commit 629672c into main Oct 20, 2025
40 checks passed
@enmande enmande deleted the auth/pm-24621/add-tests-for-profileservice branch October 20, 2025 15:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants