Skip to content

Conversation

sbrown-livefront
Copy link
Collaborator

🎟️ Tracking

https://bitwarden.atlassian.net/browse/PM-25123

📔 Objective

Removes unused verify bank request model

📸 Screenshots

⏰ Reminders before review

  • Contributor guidelines followed
  • All formatters and local linters executed and passed
  • Written new unit and / or integration tests where applicable
  • Protected functional changes with optionality (feature flags)
  • Used internationalization (i18n) for all UI strings
  • CI builds passed
  • Communicated to DevOps any deployment requirements
  • Updated any necessary documentation (Confluence, contributing docs) or informed the documentation team

🦮 Reviewer guidelines

  • 👍 (:+1:) or similar for great changes
  • 📝 (:memo:) or ℹ️ (:information_source:) for notes or general info
  • ❓ (:question:) for questions
  • 🤔 (:thinking:) or 💭 (:thought_balloon:) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion
  • 🎨 (:art:) for suggestions / improvements
  • ❌ (:x:) or ⚠️ (:warning:) for more significant problems or concerns needing attention
  • 🌱 (:seedling:) or ♻️ (:recycle:) for future improvements or indications of technical debt
  • ⛏ (:pick:) for minor or nitpick changes

@sbrown-livefront sbrown-livefront self-assigned this Oct 17, 2025
@sbrown-livefront sbrown-livefront changed the title refactor(billing): Remove unused request model [PM-25123] Remove VerifyBankAsync Code Oct 17, 2025
@sbrown-livefront sbrown-livefront marked this pull request as ready for review October 17, 2025 15:57
Copy link

codecov bot commented Oct 17, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 50.73%. Comparing base (652da96) to head (f61c27c).
⚠️ Report is 5 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #6463   +/-   ##
=======================================
  Coverage   50.73%   50.73%           
=======================================
  Files        1869     1868    -1     
  Lines       82798    82796    -2     
  Branches     7322     7322           
=======================================
  Hits        42004    42004           
+ Misses      39191    39189    -2     
  Partials     1603     1603           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Copy link
Contributor

github-actions bot commented Oct 17, 2025

Logo
Checkmarx One – Scan Summary & Details207111fa-180e-4f16-8e4b-8b5c48b0f959

Great job! No new security vulnerabilities introduced in this pull request

@sbrown-livefront sbrown-livefront requested review from a team and cyprain-okeke and removed request for a team October 17, 2025 17:58
@sbrown-livefront sbrown-livefront merged commit 43779cf into main Oct 20, 2025
40 checks passed
@sbrown-livefront sbrown-livefront deleted the billing/pm-25123/remove-verify-bank-request-model branch October 20, 2025 14:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants