Skip to content

Conversation

amorask-bitwarden
Copy link
Contributor

🎟️ Tracking

https://bitwarden.atlassian.net/browse/PM-24546

📔 Objective

Description

Removes the PM17772_AdminInitiatedSponsorships feature flag which has been validated in production. Admin-initiated Families sponsorships with notes are now a permanent feature of the platform.

Changes Made

  • Removed PM17772_AdminInitiatedSponsorships feature flag constant from src/Core/Constants.cs
  • Removed feature flag checks from OrganizationSponsorshipsController that prevented admin-initiated sponsorships and notes when the flag was disabled
  • Removed feature flag checks from SelfHostedOrganizationSponsorshipsController that prevented admin-initiated sponsorships and notes when the flag was disabled
  • Removed feature flag conditional rendering from _OrganizationForm.cshtml that hid the UseAdminSponsoredFamilies checkbox in the Admin portal

Technical Details

The feature flag previously gated:

  1. The IsAdminInitiated flag on sponsorship creation requests
  2. The Notes field on sponsorship creation requests
  3. The UseAdminSponsoredFamilies checkbox in the organization admin form

With the flag removed, these capabilities are now permanently available. Organizations can enable/disable admin-initiated sponsorships via the UseAdminSponsoredFamilies organization setting, and all sponsorships can include notes regardless of how they were
initiated.

📸 Screenshots

⏰ Reminders before review

  • Contributor guidelines followed
  • All formatters and local linters executed and passed
  • Written new unit and / or integration tests where applicable
  • Protected functional changes with optionality (feature flags)
  • Used internationalization (i18n) for all UI strings
  • CI builds passed
  • Communicated to DevOps any deployment requirements
  • Updated any necessary documentation (Confluence, contributing docs) or informed the documentation team

🦮 Reviewer guidelines

  • 👍 (:+1:) or similar for great changes
  • 📝 (:memo:) or ℹ️ (:information_source:) for notes or general info
  • ❓ (:question:) for questions
  • 🤔 (:thinking:) or 💭 (:thought_balloon:) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion
  • 🎨 (:art:) for suggestions / improvements
  • ❌ (:x:) or ⚠️ (:warning:) for more significant problems or concerns needing attention
  • 🌱 (:seedling:) or ♻️ (:recycle:) for future improvements or indications of technical debt
  • ⛏ (:pick:) for minor or nitpick changes

@github-actions
Copy link
Contributor

github-actions bot commented Oct 14, 2025

Logo
Checkmarx One – Scan Summary & Details29e26e8f-0231-455c-9bd4-100b565c3566

Great job! No new security vulnerabilities introduced in this pull request

@codecov
Copy link

codecov bot commented Oct 15, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 50.73%. Comparing base (0fb7099) to head (f931c55).

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #6456      +/-   ##
==========================================
+ Coverage   50.72%   50.73%   +0.01%     
==========================================
  Files        1866     1866              
  Lines       82702    82679      -23     
  Branches     7319     7310       -9     
==========================================
  Hits        41949    41949              
+ Misses      39150    39127      -23     
  Partials     1603     1603              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@amorask-bitwarden amorask-bitwarden changed the title Remove FF: pm-17772-admin-initiated-sponsorships [PM-24546] Remove FF: pm-17772-admin-initiated-sponsorships Oct 17, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants