-
Notifications
You must be signed in to change notification settings - Fork 1.5k
Add validation to URI Match Default Policy for Single Org prerequisite #6454
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Signed-off-by: Ben Brooks <[email protected]>
New Issues (3)Checkmarx found the following issues in this Pull Request
|
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #6454 +/- ##
==========================================
- Coverage 55.89% 51.84% -4.06%
==========================================
Files 1870 1871 +1
Lines 82369 82374 +5
Branches 7272 7272
==========================================
- Hits 46037 42703 -3334
- Misses 34626 38042 +3416
+ Partials 1706 1629 -77 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
…570-uri-match-policy-validation Signed-off-by: Ben Brooks <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please also provide unit tests for the required policy logic for this validator.
...dminConsole/OrganizationFeatures/Policies/PolicyValidators/UriMatchDefaultPolicyValidator.cs
Outdated
Show resolved
Hide resolved
...dminConsole/OrganizationFeatures/Policies/PolicyValidators/UriMatchDefaultPolicyValidator.cs
Outdated
Show resolved
Hide resolved
…dTask Signed-off-by: Ben Brooks <[email protected]>
…570-uri-match-policy-validation Signed-off-by: Ben Brooks <[email protected]>
….com/bitwarden/server into pm-25570-uri-match-policy-validation Signed-off-by: Ben Brooks <[email protected]>
I just noticed this comment too: "Please also provide unit tests for the required policy logic for this validator." I'll work on that now... |
Signed-off-by: Ben Brooks <[email protected]>
…570-uri-match-policy-validation Signed-off-by: Ben Brooks <[email protected]>
Signed-off-by: Ben Brooks <[email protected]>
Signed-off-by: Ben Brooks <[email protected]>
@jrmccannon I took a stab at the unit tests. Thanks again for your help! |
...onsole/OrganizationFeatures/Policies/PolicyValidators/UriMatchDefaultPolicyValidatorTests.cs
Outdated
Show resolved
Hide resolved
Signed-off-by: Ben Brooks <[email protected]>
…570-uri-match-policy-validation Signed-off-by: Ben Brooks <[email protected]>
Whoops. Looks like tests are failing from main :(
🎟️ Tracking
https://bitwarden.atlassian.net/browse/PM-25570
📔 Objective
Adds the prerequisite that the Single Organization policy must be enabled before the URI Match Defaults policy can be enabled.
📸 Screenshots
⏰ Reminders before review
🦮 Reviewer guidelines
:+1:
) or similar for great changes:memo:
) or ℹ️ (:information_source:
) for notes or general info:question:
) for questions:thinking:
) or 💭 (:thought_balloon:
) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion:art:
) for suggestions / improvements:x:
) or:warning:
) for more significant problems or concerns needing attention:seedling:
) or ♻️ (:recycle:
) for future improvements or indications of technical debt:pick:
) for minor or nitpick changes