Skip to content

Conversation

@cd-bitwarden
Copy link
Contributor

🎟️ Tracking

https://bitwarden.atlassian.net/browse/SM-1592

📔 Objective

This PR is for adding the controller, repository and API endpoints required for the new Secret Versions table. There are also tests added in this PR.

📸 Screenshots

⏰ Reminders before review

  • Contributor guidelines followed
  • All formatters and local linters executed and passed
  • Written new unit and / or integration tests where applicable
  • Protected functional changes with optionality (feature flags)
  • Used internationalization (i18n) for all UI strings
  • CI builds passed
  • Communicated to DevOps any deployment requirements
  • Updated any necessary documentation (Confluence, contributing docs) or informed the documentation team

🦮 Reviewer guidelines

  • 👍 (:+1:) or similar for great changes
  • 📝 (:memo:) or ℹ️ (:information_source:) for notes or general info
  • ❓ (:question:) for questions
  • 🤔 (:thinking:) or 💭 (:thought_balloon:) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion
  • 🎨 (:art:) for suggestions / improvements
  • ❌ (:x:) or ⚠️ (:warning:) for more significant problems or concerns needing attention
  • 🌱 (:seedling:) or ♻️ (:recycle:) for future improvements or indications of technical debt
  • ⛏ (:pick:) for minor or nitpick changes

@codecov
Copy link

codecov bot commented Oct 10, 2025

Codecov Report

❌ Patch coverage is 73.38710% with 66 lines in your changes missing coverage. Please review.
✅ Project coverage is 52.07%. Comparing base (b15913c) to head (4877f13).

Files with missing lines Patch % Lines
...etsManager/Controllers/SecretVersionsController.cs 64.53% 36 Missing and 14 partials ⚠️
...r/Repositories/Noop/NoopSecretVersionRepository.cs 0.00% 12 Missing ⚠️
...pi/SecretsManager/Controllers/SecretsController.cs 84.61% 3 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #6444      +/-   ##
==========================================
+ Coverage   51.98%   52.07%   +0.09%     
==========================================
  Files        1872     1877       +5     
  Lines       82537    82785     +248     
  Branches     7299     7326      +27     
==========================================
+ Hits        42908    43112     +204     
- Misses      37972    37999      +27     
- Partials     1657     1674      +17     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@github-actions
Copy link
Contributor

github-actions bot commented Oct 10, 2025

Logo
Checkmarx One – Scan Summary & Detailse831f3fb-cb60-4e31-a8ef-a3f381b21154

Great job! No new security vulnerabilities introduced in this pull request

@cd-bitwarden cd-bitwarden marked this pull request as ready for review October 23, 2025 18:36
@cd-bitwarden cd-bitwarden requested a review from Hinton October 23, 2025 18:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants