Skip to content

[PM-26714] Add unit tests for OrganizationService.InviteUsers to assert that autoscale emails are sent when expected #6434

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 2 commits into
base: main
Choose a base branch
from
Draft

[PM-26714] Add unit tests for OrganizationService.InviteUsers to assert that autoscale emails are sent when expected #6434

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
a1fe82a
Add unit tests for OrganizationService.InviteUsers to assert that aut…
r-tome Oct 9, 2025
67f4a9d
Merge branch 'main' into ac/pm-26714/seat-count-increase-email-not-be…
r-tome Oct 10, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
103 changes: 103 additions & 0 deletions test/Core.Test/AdminConsole/Services/OrganizationServiceTests.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1330,6 +1330,109 @@ await sutProvider.GetDependency<IOrganizationRepository>()
.GetByIdAsync(organizationId);
}

[Theory]
[OrganizationInviteCustomize(InviteeUserType = OrganizationUserType.User,
InvitorUserType = OrganizationUserType.Owner), OrganizationCustomize, BitAutoData]
public async Task InviteUsers_WhenSeatCountIncreasesAndOwnersNotNotified_SendsAutoscaledEmailOnce(
Organization organization,
OrganizationUser invitor,
[OrganizationUser(OrganizationUserStatusType.Confirmed, OrganizationUserType.Owner)] OrganizationUser owner,
OrganizationUserInvite invite,
SutProvider<OrganizationService> sutProvider)
{
// Arrange
sutProvider.SetDependency(_orgUserInviteTokenDataFactory, "orgUserInviteTokenDataFactory");
sutProvider.Create();

organization.Seats = 1;
organization.SmSeats = 0;
organization.OwnersNotifiedOfAutoscaling = null;
organization.GatewayCustomerId = "customer_id";
organization.GatewaySubscriptionId = "subscription_id";
invite.Emails = invite.Emails.Take(1);
invite.AccessSecretsManager = false;

sutProvider.GetDependency<IOrganizationRepository>().GetByIdAsync(organization.Id).Returns(organization);
sutProvider.GetDependency<IOrganizationRepository>().GetOccupiedSeatCountByOrganizationIdAsync(organization.Id)
.Returns(new OrganizationSeatCounts { Sponsored = 0, Users = 1 });
sutProvider.GetDependency<IOrganizationUserRepository>().GetManyByMinimumRoleAsync(organization.Id, OrganizationUserType.Owner)
.ReturnsForAnyArgs([new OrganizationUserUserDetails { Id = owner.Id, Email = owner.Email }]);
sutProvider.GetDependency<IOrganizationUserRepository>().SelectKnownEmailsAsync(organization.Id, Arg.Any<IEnumerable<string>>(), false)
.Returns(Array.Empty<string>());
sutProvider.GetDependency<ICurrentContext>().OrganizationOwner(organization.Id).Returns(true);
sutProvider.GetDependency<ICurrentContext>().ManageUsers(organization.Id).Returns(true);
sutProvider.GetDependency<IHasConfirmedOwnersExceptQuery>()
.HasConfirmedOwnersExceptAsync(organization.Id, Arg.Any<IEnumerable<Guid>>(), Arg.Any<bool>()).Returns(true);
sutProvider.GetDependency<ICountNewSmSeatsRequiredQuery>()
.CountNewSmSeatsRequiredAsync(organization.Id, Arg.Any<int>()).Returns(0);
sutProvider.GetDependency<IPricingClient>().GetPlanOrThrow(organization.PlanType).Returns(StaticStore.GetPlan(organization.PlanType));
sutProvider.GetDependency<IPaymentService>().AdjustSeatsAsync(Arg.Any<Organization>(), Arg.Any<Bit.Core.Models.StaticStore.Plan>(), Arg.Any<int>())
.Returns(Task.FromResult<string>(null));
sutProvider.GetDependency<IGlobalSettings>().SelfHosted.Returns(false);
SetupOrgUserRepositoryCreateManyAsyncMock(sutProvider.GetDependency<IOrganizationUserRepository>());

// Act
await sutProvider.Sut.InviteUsersAsync(organization.Id, invitor.UserId, systemUser: null, invites: [(invite, null)]);

// Assert
await sutProvider.GetDependency<IMailService>()
.Received(1)
.SendOrganizationAutoscaledEmailAsync(
Arg.Is<Organization>(o => o.Id == organization.Id),
initialSeatCount: 1,
Arg.Is<IEnumerable<string>>(emails => emails.Contains(owner.Email)));
await sutProvider.GetDependency<IOrganizationRepository>()
.Received(1)
.UpsertAsync(
Arg.Is<Organization>(o => o.Id == organization.Id && o.OwnersNotifiedOfAutoscaling.HasValue));
}

[Theory]
[OrganizationInviteCustomize(InviteeUserType = OrganizationUserType.User,
InvitorUserType = OrganizationUserType.Owner), OrganizationCustomize, BitAutoData]
public async Task InviteUsers_WhenOwnersAlreadyNotified_DoesNotSendAutoscaleEmail(
Organization organization,
OrganizationUser invitor,
OrganizationUserInvite invite,
SutProvider<OrganizationService> sutProvider)
{
// Arrange
sutProvider.SetDependency(_orgUserInviteTokenDataFactory, "orgUserInviteTokenDataFactory");
sutProvider.Create();

organization.Seats = 1;
organization.SmSeats = 0;
organization.OwnersNotifiedOfAutoscaling = DateTime.UtcNow.AddDays(-1);
organization.GatewayCustomerId = "customer_id";
organization.GatewaySubscriptionId = "subscription_id";
invite.Emails = invite.Emails.Take(1);
invite.AccessSecretsManager = false;

sutProvider.GetDependency<IOrganizationRepository>().GetByIdAsync(organization.Id).Returns(organization);
sutProvider.GetDependency<IOrganizationRepository>().GetOccupiedSeatCountByOrganizationIdAsync(organization.Id)
.Returns(new OrganizationSeatCounts { Sponsored = 0, Users = 1 });
sutProvider.GetDependency<IOrganizationUserRepository>().SelectKnownEmailsAsync(organization.Id, Arg.Any<IEnumerable<string>>(), false)
.Returns(Array.Empty<string>());
sutProvider.GetDependency<ICurrentContext>().OrganizationOwner(organization.Id).Returns(true);
sutProvider.GetDependency<ICurrentContext>().ManageUsers(organization.Id).Returns(true);
sutProvider.GetDependency<IHasConfirmedOwnersExceptQuery>()
.HasConfirmedOwnersExceptAsync(organization.Id, Arg.Any<IEnumerable<Guid>>(), Arg.Any<bool>()).Returns(true);
sutProvider.GetDependency<ICountNewSmSeatsRequiredQuery>()
.CountNewSmSeatsRequiredAsync(organization.Id, Arg.Any<int>()).Returns(0);
sutProvider.GetDependency<IPricingClient>().GetPlanOrThrow(organization.PlanType).Returns(StaticStore.GetPlan(organization.PlanType));
sutProvider.GetDependency<IPaymentService>().AdjustSeatsAsync(Arg.Any<Organization>(), Arg.Any<Bit.Core.Models.StaticStore.Plan>(), Arg.Any<int>())
.Returns(Task.FromResult<string>(null));
sutProvider.GetDependency<IGlobalSettings>().SelfHosted.Returns(false);
SetupOrgUserRepositoryCreateManyAsyncMock(sutProvider.GetDependency<IOrganizationUserRepository>());

// Act
await sutProvider.Sut.InviteUsersAsync(organization.Id, invitor.UserId, systemUser: null, invites: [(invite, null)]);

// Assert
await sutProvider.GetDependency<IMailService>().DidNotReceive().SendOrganizationAutoscaledEmailAsync(
Arg.Any<Organization>(), Arg.Any<int>(), Arg.Any<IEnumerable<string>>());
}

// Must set real guids in order for dictionary of guids to not throw aggregate exceptions
private void SetupOrgUserRepositoryCreateManyAsyncMock(IOrganizationUserRepository organizationUserRepository)
{
Expand Down
Loading