-
Notifications
You must be signed in to change notification settings - Fork 18
Cleanup dependencies #466
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Cleanup dependencies #466
Conversation
Great job! No new security vulnerabilities introduced in this pull request |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #466 +/- ##
==========================================
+ Coverage 78.25% 78.27% +0.01%
==========================================
Files 275 275
Lines 27447 27438 -9
==========================================
- Hits 21479 21476 -3
+ Misses 5968 5962 -6 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
BW auth crate changes look good to me. Thank you for the clean up!
🎟️ Tracking
📔 Objective
Removes some unnecessary dependencies from
bitwarden-auth
.serde_json
only used in tests.serde_qs
never used.serde_urlencoded
replaced manual form handling with the.form
method fromreqwest
.Changed
bitwarden-uniffi-error
to be optional and removeduniffi
as a dependency from it.⏰ Reminders before review
team
🦮 Reviewer guidelines
:+1:
) or similar for great changes:memo:
) or ℹ️ (:information_source:
) for notes or general info:question:
) for questions:thinking:
) or 💭 (:thought_balloon:
) for more open inquiry that's not quite a confirmedissue and could potentially benefit from discussion
:art:
) for suggestions / improvements:x:
) or:warning:
) for more significant problems or concerns needing attention:seedling:
) or ♻️ (:recycle:
) for future improvements or indications of technical debt:pick:
) for minor or nitpick changes