Skip to content

[RFC] Add parse fuzzing via cargo fuzz #345

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weโ€™ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from
Draft

[RFC] Add parse fuzzing via cargo fuzz #345

wants to merge 1 commit into from

Conversation

quexten
Copy link
Contributor

@quexten quexten commented Jul 5, 2025

๐ŸŽŸ๏ธ Tracking

๐Ÿ“” Objective

Adds fuzzing. In this case, the test cases would only detect panic(unwrap/expect). For parse_passkey, the following failing input is discovered:

        Fido2CredentialFullView {
            credential_id: "",
            key_type: "",
            key_algorithm: "",
            key_curve: "",
            key_value: "",
            rp_id: "",
            user_handle: None,
            user_name: None,
            counter: "",
            rp_name: None,
            user_display_name: None,
            discoverable: "",
            creation_date: 1970-01-01T00:00:00Z,
        }

from this expect:

let counter: u32 = value.counter.parse().expect("Invalid counter");
.

Fix in: #346

I have not further audited where this is called.

โฐ Reminders before review

  • Contributor guidelines followed
  • All formatters and local linters executed and passed
  • Written new unit and / or integration tests where applicable
  • Protected functional changes with optionality (feature flags)
  • Used internationalization (i18n) for all UI strings
  • CI builds passed
  • Communicated to DevOps any deployment requirements
  • Updated any necessary documentation (Confluence, contributing docs) or informed the documentation
    team

๐Ÿฆฎ Reviewer guidelines

  • ๐Ÿ‘ (:+1:) or similar for great changes
  • ๐Ÿ“ (:memo:) or โ„น๏ธ (:information_source:) for notes or general info
  • โ“ (:question:) for questions
  • ๐Ÿค” (:thinking:) or ๐Ÿ’ญ (:thought_balloon:) for more open inquiry that's not quite a confirmed
    issue and could potentially benefit from discussion
  • ๐ŸŽจ (:art:) for suggestions / improvements
  • โŒ (:x:) or โš ๏ธ (:warning:) for more significant problems or concerns needing attention
  • ๐ŸŒฑ (:seedling:) or โ™ป๏ธ (:recycle:) for future improvements or indications of technical debt
  • โ› (:pick:) for minor or nitpick changes

Copy link
Contributor

github-actions bot commented Jul 5, 2025

Logo
Checkmarx One โ€“ Scan Summary & Details โ€“ 2c74d80f-46f3-4859-9849-7d81d2b84f20

New Issues (2)

Checkmarx found the following issues in this Pull Request

Severity Issue Source File / Package Checkmarx Insight
MEDIUM CVE-2024-29409 Npm-@nestjs/common-10.4.6
detailsRecommended version: 10.4.16
Description: A File upload vulnerability in NestJS allows a remote attacker to execute arbitrary code through the Content-Type header. Versions through 10.4.15 ...
Attack Vector: NETWORK
Attack Complexity: LOW

ID: Q9Lr%2F8bJfsOUXKkIQCvVwrfISR6Da6bDLGUEnzhH8oI%3D
Vulnerable Package
LOW CVE-2025-5889 Npm-brace-expansion-2.0.1
detailsRecommended version: 2.0.2
Description: A vulnerability was found in juliangruber brace-expansion. It has been rated as problematic. Affected by this issue is the function "expand" of the...
Attack Vector: NETWORK
Attack Complexity: HIGH

ID: QvJcYAv47jyUKiGf%2FQMuU7p6cPGHr65PIsTDqQ0Nrko%3D
Vulnerable Package

Copy link

sonarqubecloud bot commented Jul 5, 2025

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant