[PM-23022] Re-sort bitwarden-crypto crate #344
Draft
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🎟️ Tracking
https://bitwarden.atlassian.net/browse/PM-23392
📔 Objective
Moves public-key (asymmetric) encryption, and symmetric encryption into dedicated folders. Low-level implementations are moved to "hazmat" sub-folders that are only available from super. Asymmetric encryption is split into a public key and private key file, similar to signingkey / verifying key in
signing
. The cose symmetric encryption logic is split out into a separate symmetric-encryption specific cose file.Otherwise, this PR does not intend to rename or change implementations. A small change to key-wrap was necessary, so that the hazmat module does not need to be pub(crate).
Notably
rsa
is only partially moved and requires more refactors to be fully moved. This was used outside of the crate, and the necessary re-factors are out-of scope here.⏰ Reminders before review
team
🦮 Reviewer guidelines
:+1:
) or similar for great changes:memo:
) or ℹ️ (:information_source:
) for notes or general info:question:
) for questions:thinking:
) or 💭 (:thought_balloon:
) for more open inquiry that's not quite a confirmedissue and could potentially benefit from discussion
:art:
) for suggestions / improvements:x:
) or:warning:
) for more significant problems or concerns needing attention:seedling:
) or ♻️ (:recycle:
) for future improvements or indications of technical debt:pick:
) for minor or nitpick changes