-
Notifications
You must be signed in to change notification settings - Fork 9
[PM-20361] Expose signing key generation to mobile and wasm clients & add to key context #257
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: km/cose-signatures
Are you sure you want to change the base?
Conversation
…ic keyencryptable trait impl
…rden/sdk-internal into km/poc-update-asymmetric-interface
Great job, no security vulnerabilities found in this Pull Request |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## km/cose-signatures #257 +/- ##
=====================================================
Coverage ? 67.40%
=====================================================
Files ? 214
Lines ? 16639
Branches ? 0
=====================================================
Hits ? 11215
Misses ? 5424
Partials ? 0 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
f8044bd
to
c9b80df
Compare
🎟️ Tracking
https://bitwarden.atlassian.net/browse/PM-20361
📔 Objective
Adds signing keys to the key context, and adds functions to make signature keys to the sdk.
⏰ Reminders before review
team
🦮 Reviewer guidelines
:+1:
) or similar for great changes:memo:
) or ℹ️ (:information_source:
) for notes or general info:question:
) for questions:thinking:
) or 💭 (:thought_balloon:
) for more open inquiry that's not quite a confirmedissue and could potentially benefit from discussion
:art:
) for suggestions / improvements:x:
) or:warning:
) for more significant problems or concerns needing attention:seedling:
) or ♻️ (:recycle:
) for future improvements or indications of technical debt:pick:
) for minor or nitpick changes