[PM-20957] Update UniFFI to 0.29.1 #256
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1 task
dani-garcia
changed the title
|
Great job, no security vulnerabilities found in this Pull Request |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #256 +/- ##
==========================================
+ Coverage 69.56% 69.61% +0.05%
==========================================
Files 213 218 +5
Lines 16644 16617 -27
==========================================
- Hits 11578 11568 -10
+ Misses 5066 5049 -17 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Hinton
approved these changes
May 1, 2025
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🎟️ Tracking
https://bitwarden.atlassian.net/browse/PM-20957
📔 Objective
This replaces the renovate PR as the changes are fairly big.
Update UniFFI to version 0.29.1. This requires bumping MSRV to 1.82, as that's the requirement from UniFFI.
The migration consists of a few parts:
UniffiCustomTypeConverterby the simplercustom_type!macro. Note that for types defined in other crates, we still use the same macro, but with theremote,value added.ffi_converter_forward!:use_remote_type!uniffi::deps::logby thelogcrate directly.LinkedId, I've noticed that we had two implementations ofTryFrom<U32>, the one used by uniffi based on deserialize, and a hardcoded map. I've combined them in one using the deserialize strategy.I've tested this on the Android and iOS native apps, and they both compile and decrypt the vault without issues.
⏰ Reminders before review
team
🦮 Reviewer guidelines
:+1:) or similar for great changes:memo:) or ℹ️ (:information_source:) for notes or general info:question:) for questions:thinking:) or 💭 (:thought_balloon:) for more open inquiry that's not quite a confirmedissue and could potentially benefit from discussion
:art:) for suggestions / improvements:x:) or:warning:) for more significant problems or concerns needing attention:seedling:) or ♻️ (:recycle:) for future improvements or indications of technical debt:pick:) for minor or nitpick changes