Unify WASM crypto client with mobile #226
Conversation
| } | ||
| } | ||
|
|
||
| impl CryptoClient { |
There was a problem hiding this comment.
I've split the impl CryptoClient into two blocks, one with wasm_bindgen for the functions we're currently exporting to wasm, and one without it for the ones that we're not using.
We could also export all of them if we wanted, but to keep the PR simple I only include the ones actually in use.
| @@ -49,6 +50,7 @@ tsify-next = { workspace = true, optional = true } | |||
| uniffi = { workspace = true, optional = true, features = ["tokio"] } | |||
| uuid = { workspace = true } | |||
| wasm-bindgen = { workspace = true, optional = true } | |||
| wasm-bindgen-futures = { workspace = true, optional = true } | |||
There was a problem hiding this comment.
This dep is used internally for the wasm-bindgen macro as cryptoclient has some async functions.
|
Great job, no security vulnerabilities found in this Pull Request |
|
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #226 +/- ##
==========================================
+ Coverage 66.81% 66.92% +0.10%
==========================================
Files 213 212 -1
Lines 15922 15901 -21
==========================================
+ Hits 10638 10641 +3
+ Misses 5284 5260 -24 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
🎟️ Tracking
📔 Objective
With the removal of the lifetimes of the clients, we can remove the wasm-specific crypto client and instead use the one in bitwarden-core.
⏰ Reminders before review
team
🦮 Reviewer guidelines
:+1:) or similar for great changes:memo:) or ℹ️ (:information_source:) for notes or general info:question:) for questions:thinking:) or 💭 (:thought_balloon:) for more open inquiry that's not quite a confirmedissue and could potentially benefit from discussion
:art:) for suggestions / improvements:x:) or:warning:) for more significant problems or concerns needing attention:seedling:) or ♻️ (:recycle:) for future improvements or indications of technical debt:pick:) for minor or nitpick changes