Unify WASM crypto client with mobile

[dani-garcia]

🎟️ Tracking

📔 Objective

With the removal of the lifetimes of the clients, we can remove the wasm-specific crypto client and instead use the one in bitwarden-core.

⏰ Reminders before review

• Contributor guidelines followed
• All formatters and local linters executed and passed
• Written new unit and / or integration tests where applicable
• Protected functional changes with optionality (feature flags)
• Used internationalization (i18n) for all UI strings
• CI builds passed
• Communicated to DevOps any deployment requirements
• Updated any necessary documentation (Confluence, contributing docs) or informed the documentation
  team

🦮 Reviewer guidelines

• 👍 (:+1:) or similar for great changes
• 📝 (:memo:) or ℹ️ (:information_source:) for notes or general info
• ❓ (:question:) for questions
• 🤔 (:thinking:) or 💭 (:thought_balloon:) for more open inquiry that's not quite a confirmed
  issue and could potentially benefit from discussion
• 🎨 (:art:) for suggestions / improvements
• ❌ (:x:) or ⚠️ (:warning:) for more significant problems or concerns needing attention
• 🌱 (:seedling:) or ♻️ (:recycle:) for future improvements or indications of technical debt
• ⛏ (:pick:) for minor or nitpick changes

[github-actions]

Checkmarx One – Scan Summary & Details – 9dfcf77b-6a0c-40f7-a492-a717a88a747a

Great job, no security vulnerabilities found in this Pull Request

[sonarqubecloud]

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

[codecov]

Codecov Report

Attention: Patch coverage is 36.66667% with 19 lines in your changes missing coverage. Please review.

Project coverage is 70.36%. Comparing base (09fe7cd) to head (2cb7e02).
Report is 2 commits behind head on main.

Files with missing lines	Patch %	Lines
...bitwarden-core/src/key_management/crypto_client.rs	0.00%	13 Missing ⚠️
crates/bitwarden-core/src/key_management/crypto.rs	50.00%	5 Missing ⚠️
crates/bitwarden-wasm-internal/src/client.rs	0.00%	1 Missing ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##             main     #226      +/-   ##
==========================================
+ Coverage   70.29%   70.36%   +0.07%     
==========================================
  Files         216      215       -1     
  Lines       17060    17043      -17     
==========================================
+ Hits        11992    11993       +1     
+ Misses       5068     5050      -18     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
• 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

[Hinton]

suggestion: Could we lift this out of mobile?

[dani-garcia]

Sounds reasonable yeah, do you think we should just lift it into the root? Or maybe into the key-management folder?

[Hinton]

I think we can lift it into KM, @quexten would you be alright with that, I think everything currently falls under KM domain.

[quexten]

Seems reasonable!

My question here (non-blocking, but needs clarification): Does key-management (the folder) really refer to the KM team, or the key-management capabilities (key store, key context) of the sdk?

The KM domain is not directly the same (Biometrics, Crypto Primitives).

[dani-garcia]

So the way I'm thinking about this is like this:

The crypto client that I'm moving to the key_management folder is mostly a thin compatibility layer on top of the bitwarden-crypto types to make the functionality more usable for FFI (By exposing a client, instead of relying on types like MasterKey, etc, which aren't usable in FFI). In that sense, once KM officially owns bitwarden-crypto, this folder should come with, as it's fairly tied to the API exposed by bitwarden-crypto. In the future, if we find a way to expose the normal bitwarden-crypto API through FFI this module could be removed.

The other thing in the key_management folder is the definition of KeyIds used by the Key Store from bitwarden-crypto. I think of this and the Key Store as part of KM's field to expose safe to use crypto, so in my mind it would be part of your domain. The reason I defined these outside the crypto crate was to ensure the system was generic and easily expandable, but I'm not sure if that's worth it. If not, we can always move it into bitwarden-crypto directly and simplify ownership.

[sonarqubecloud]

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud