Skip to content

[PM-20614] Cose Content Type #203

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 7 commits into
base: main
Choose a base branch
from
Draft

[PM-20614] Cose Content Type #203

wants to merge 7 commits into from

Conversation

quexten
Copy link
Contributor

@quexten quexten commented Mar 27, 2025

🎟️ Tracking

https://bitwarden.atlassian.net/browse/PM-20614

📔 Objective

⏰ Reminders before review

  • Contributor guidelines followed
  • All formatters and local linters executed and passed
  • Written new unit and / or integration tests where applicable
  • Protected functional changes with optionality (feature flags)
  • Used internationalization (i18n) for all UI strings
  • CI builds passed
  • Communicated to DevOps any deployment requirements
  • Updated any necessary documentation (Confluence, contributing docs) or informed the documentation
    team

🦮 Reviewer guidelines

  • 👍 (:+1:) or similar for great changes
  • 📝 (:memo:) or ℹ️ (:information_source:) for notes or general info
  • ❓ (:question:) for questions
  • 🤔 (:thinking:) or 💭 (:thought_balloon:) for more open inquiry that's not quite a confirmed
    issue and could potentially benefit from discussion
  • 🎨 (:art:) for suggestions / improvements
  • ❌ (:x:) or ⚠️ (:warning:) for more significant problems or concerns needing attention
  • 🌱 (:seedling:) or ♻️ (:recycle:) for future improvements or indications of technical debt
  • ⛏ (:pick:) for minor or nitpick changes

Copy link
Contributor

github-actions bot commented Mar 27, 2025

Logo
Checkmarx One – Scan Summary & Details7103ecd9-17fe-4727-987a-ac41a9985694

Great job, no security vulnerabilities found in this Pull Request

@quexten quexten changed the title Km/cose content format Cose Content Type Mar 27, 2025
Copy link

codecov bot commented Mar 28, 2025

Codecov Report

Attention: Patch coverage is 71.19438% with 123 lines in your changes missing coverage. Please review.

Project coverage is 69.89%. Comparing base (5449a5a) to head (d6a18a4).

Files with missing lines Patch % Lines
crates/bitwarden-vault/src/cipher/identity.rs 0.00% 21 Missing ⚠️
crates/bitwarden-vault/src/cipher/login.rs 54.05% 17 Missing ⚠️
...rates/bitwarden-crypto/src/keys/key_encryptable.rs 0.00% 13 Missing ⚠️
...twarden_license/bitwarden-sm/src/secrets/create.rs 0.00% 12 Missing ⚠️
...twarden_license/bitwarden-sm/src/secrets/update.rs 0.00% 12 Missing ⚠️
crates/bitwarden-vault/src/cipher/card.rs 0.00% 9 Missing ⚠️
...rates/bitwarden-crypto/src/enc_string/symmetric.rs 81.81% 6 Missing ⚠️
crates/bitwarden-exporters/src/export.rs 0.00% 5 Missing ⚠️
crates/bitwarden-crypto/src/cose.rs 81.81% 4 Missing ⚠️
crates/bitwarden-vault/src/cipher/ssh_key.rs 0.00% 4 Missing ⚠️
... and 14 more
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #203      +/-   ##
==========================================
+ Coverage   69.81%   69.89%   +0.07%     
==========================================
  Files         213      213              
  Lines       16809    17041     +232     
==========================================
+ Hits        11735    11910     +175     
- Misses       5074     5131      +57     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Base automatically changed from km/cose to main May 6, 2025 15:13
@quexten quexten changed the base branch from main to km/wrapped-key May 7, 2025 10:47
@quexten quexten changed the base branch from km/wrapped-key to main May 8, 2025 23:05
@quexten quexten changed the title Cose Content Type [PM-20614] Cose Content Type May 8, 2025
@quexten quexten force-pushed the km/cose-content-format branch from f862c19 to e04b781 Compare May 9, 2025 09:20
@quexten quexten force-pushed the km/cose-content-format branch from e04b781 to bc5900b Compare May 9, 2025 09:27
Copy link

sonarqubecloud bot commented May 9, 2025

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant