Updating SDK to 8266e16 (1.0.0-2742-fc75b90) #2045
Merged
+9
−5
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![bw-ghapp[bot]](https://avatars.githubusercontent.com/u/15990069?s=80&v=4){kind=small}
bw-ghapp
bot
added
automated-pr
|
Great job! No new security vulnerabilities introduced in this pull request |
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #2045 +/- ##
==========================================
- Coverage 85.28% 82.94% -2.35%
==========================================
Files 1690 1987 +297
Lines 144061 160900 +16839
==========================================
+ Hits 122862 133455 +10593
- Misses 21199 27445 +6246 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
bw-ghapp
bot
changed the title
| await flightRecorder.log("[Auth] Set PIN-protected user key in memory") | ||
| } | ||
| case .pinEnvelope: | ||
| case .masterPasswordUnlock, |
There was a problem hiding this comment.
🎨 Master password unlock should follow the same flow as password unlock; so even though we aren't using it yet, I think we should move this alongside the .password case above which configures PIN unlock after unlocking the vault.
Comment on lines
23
to
24
| case .masterPasswordUnlock: | ||
| "Master Password Unlock" |
There was a problem hiding this comment.
⛏️ Can you alphabetize this relative to the other cases?
fedemkr
approved these changes
Oct 17, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updates the SDK from
1e16ec0e5e3f7045a82b747dc9cf5ddf06e13448to8266e167ae8e80f1bf1e9ab96ee5a4d46162c059What's Changed
Raw changelog