[PM-26809] Prepare Claude configuration

[fedemkr]

🎟️ Tracking

PM-26809

📔 Objective

Prepare .claude/ configuration files with multiple agents based on https://github.com/dasien/ClaudeMultiAgentTemplate.

Also updated Architecture.md and added Testing.md docs to the repo to add further details to them.

⏰ Reminders before review

• Contributor guidelines followed
• All formatters and local linters executed and passed
• Written new unit and / or integration tests where applicable
• Protected functional changes with optionality (feature flags)
• Used internationalization (i18n) for all UI strings
• CI builds passed
• Communicated to DevOps any deployment requirements
• Updated any necessary documentation (Confluence, contributing docs) or informed the documentation team

🦮 Reviewer guidelines

• 👍 (:+1:) or similar for great changes
• 📝 (:memo:) or ℹ️ (:information_source:) for notes or general info
• ❓ (:question:) for questions
• 🤔 (:thinking:) or 💭 (:thought_balloon:) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion
• 🎨 (:art:) for suggestions / improvements
• ❌ (:x:) or ⚠️ (:warning:) for more significant problems or concerns needing attention
• 🌱 (:seedling:) or ♻️ (:recycle:) for future improvements or indications of technical debt
• ⛏ (:pick:) for minor or nitpick changes

[KatherineInCode]

🤔 Part of me wonders if this will be sufficient for BWA, or if we need to call BWA out separately, or if we should work at getting some of these files actually migrated to BitwardenKit

[fedemkr]

I will rewrite this to take into account both apps. Even though we could move some things into BitwardenKit there are some objects/services that are particular of each app so we will still need the specific app ServiceContainers; so we should still be documenting them.

[KatherineInCode]

🤔 Should this explicitly call out that we can have multiple test files per class?

[SaintPatrck]

I think we should. Something like...

Suggested change

	- **Testing**: Test file goes in same folder as implementation (e.g., `FooProcessor.swift` + `FooProcessorTests.swift`)
	- **Testing**: Test files go in the same folder as the implementation (e.g., `FooProcessor.swift` + `FooProcessorTests.swift`). Multiple test files can be used for a single class to improve readability.

[fedemkr]

I can add a direct link to the testing docs explanation on contributing docs as in there, it's explained how test files are organized. Also will make it plural.

[github-actions]

Checkmarx One – Scan Summary & Details – c9cfb877-8b21-4b48-a998-95a89fb573a5

Great job! No new security vulnerabilities introduced in this pull request

[SaintPatrck]

Blank bullet can be removed.

[fedemkr]

Work in progress need to add some things in there; missed to add them before committing. Thanks for catching this!

[SaintPatrck]

Extra newline can be removed.

[SaintPatrck]

🧠 ⛈️ I've found terminology like "should not" to be less effective than using more direct phrases like, "You MUST NOT do x." When possible, providing reasoning is also helpful to express criticality in following instructions.

- You **MUST NOT** install third-party libraries unless explicitly told to.
- New encryption logic **MUST NOT** be added to this repository.
- Before providing any code or making changes, you **MUST** have read and understood the "iOS Client Architecture" and "Code Style" documents listed in the References section.

[SaintPatrck]

Can we elaborate on this?

Suggested change

	- Test files named `<TypeToTest>Tests.swift` in same folder
	Test files must be named `<TypeToTest>Tests.swift` and be located in the same folder as the file being tested.

[SaintPatrck]

This is repeated from the Common patterns section. I'm wondering if there's actually value in it being in both places. 🤔

[SaintPatrck]

⛏️ Can we elaborate more here, too?

Suggested change

	- Test in light mode, dark mode, and large dynamic type
	- Tests must pass in light mode, dark mode, and large dynamic type.

[SaintPatrck]

🤔 It may be helpful to provide instructions on how to run tests.

Suggested change

	### How to Run Tests
	- After making changes, run the tests for the relevant scheme in Xcode to ensure your changes have not broken anything.
	- You can also run tests from the command line using `xcodebuild`.

[SaintPatrck]

I think it would be helpful to add a clear purpose statement so Claude has immediate context and directive. Something like

This document provides the necessary context and rules for you, an expert iOS developer, to contribute to the Bitwarden iOS project.

## Project Context Files

**Read these files first to fully understand the project and contributing guidelines.**

Files prefixed with `@` are references to other files in this `.ai` directory. You MUST read them for context before proceeding.

The bottom "Files prefixed with @...", part is to clarify file notation since it varies throughout the doc. Some places, like L7-L9, are prefixed @ while others use hyperlinks pointing to the file.

[fedemkr]

Agree, I'll add that. I think I can just switch to use @ in all places as it's the preferred way on Claude docs to avoid stating it here.

[codecov]

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 85.31%. Comparing base (d6cd64f) to head (ff96d0b).

Additional details and impacted files

@@           Coverage Diff           @@
##             main    #2039   +/-   ##
=======================================
  Coverage   85.31%   85.31%           
=======================================
  Files        1691     1691           
  Lines      144372   144372           
=======================================
+ Hits       123168   123169    +1     
+ Misses      21204    21203    -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

[KatherineInCode]

🤔 Forgive my ignorance, but what's a 6502 kernel do in the context of iOS development?