[PM-21187] Rename Azure AD to Entra ID #797
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
✅ All tests successful. No failed tests found. Additional details and impacted files@@ Coverage Diff @@
## main #797 +/- ##
========================================
- Coverage 7.73% 7.72% -0.02%
========================================
Files 68 68
Lines 2754 2759 +5
Branches 474 475 +1
========================================
Hits 213 213
- Misses 2526 2531 +5
Partials 15 15 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
New Issues (3)Checkmarx found the following issues in this Pull Request
|
BTreston
requested changes
Jun 23, 2025
src/services/state.service.ts
Outdated
| const azureConfig = config as AzureConfiguration; | ||
| await this.setAzureKey(azureConfig.key); | ||
| case DirectoryType.EntraID: { | ||
| const azureConfig = config as EntraIdConfiguration; |
There was a problem hiding this comment.
should probably be renamed:
Suggested change
| const azureConfig = config as EntraIdConfiguration; | |
| const entraIdConfig = config as EntraIdConfiguration; |
jrmccannon
force-pushed
the
jmccannon/ac/pm-21187-entraid
branch
from
788d035 to
97e7b95
Compare
BTreston
previously approved these changes
Jun 23, 2025
eliykat
requested changes
Jun 24, 2025
|
When QA test this, please get ask them to test the upgrade path to ensure that the Azure/Entra config and key aren't lost when upgrading between versions. |
Co-authored-by: Thomas Rittson <[email protected]>
eliykat
requested changes
Jun 25, 2025
|
eliykat
approved these changes
Jun 26, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🎟️ Tracking
PM-21187
📔 Objective
This renames Azure AD to Entra ID. It includes file names and commands. Existing configs should continue to work, but will be assigned to entra config behind the scenes.
📸 Screenshots
⏰ Reminders before review
🦮 Reviewer guidelines
:+1:) or similar for great changes:memo:) or ℹ️ (:information_source:) for notes or general info:question:) for questions:thinking:) or 💭 (:thought_balloon:) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion:art:) for suggestions / improvements:x:) or:warning:) for more significant problems or concerns needing attention:seedling:) or ♻️ (:recycle:) for future improvements or indications of technical debt:pick:) for minor or nitpick changes