-
Notifications
You must be signed in to change notification settings - Fork 22
Add MariaDB instructions and clarify EF testing #687
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Deploying contributing-docs with
|
Latest commit: |
abbc4e0
|
Status: | ✅ Deploy successful! |
Preview URL: | https://10b81921.contributing-docs.pages.dev |
Branch Preview URL: | https://mariadb.contributing-docs.pages.dev |
Claude finished @eliykat's task —— View job PR Review: Add MariaDB instructions and clarify EF testingCompleted review of the documentation changes for accuracy, clarity, and formatting. Review SummaryThis PR successfully adds MariaDB support documentation and improves the overall clarity of database setup instructions. The changes are well-structured and follow the established documentation patterns. ✅ Positive Changes📝 Content Quality:
🎨 Structure & Style:
🔧 Technical Accuracy:
🎯 Key Improvements Madedocs/getting-started/server/database/ef/index.mdx:
docs/contributing/testing/database/index.md:
📚 Documentation Standards Compliance
🏆 Overall AssessmentThis is a high-quality documentation update that:
The changes will make it much easier for developers to set up and test with different database providers, which aligns perfectly with Bitwarden's multi-database support strategy. Recommendation: ✅ Approve |
Great job! No new security vulnerabilities introduced in this pull request |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One ⛏️ because I just updated all the headings in this repo. Thanks for all these clarifications!
|
||
::: | ||
|
||
### Run Migrations |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
### Run Migrations | |
### Run migrations |
Claude finished @eliykat's task —— View job PR Review: Add MariaDB instructions and clarify EF testingI've completed a comprehensive review of the documentation changes for accuracy, clarity, and formatting compliance. Todo List
Review SummaryThis PR successfully adds MariaDB support documentation and improves the overall clarity of database setup instructions. The changes are well-structured and follow the established documentation patterns. ✅ Positive Changes📝 Content Quality:
🎨 Structure & Style:
🔧 Technical Accuracy:
🎯 Key Improvements Madedocs/getting-started/server/database/ef/index.mdx:
docs/contributing/testing/database/index.md:
📚 Documentation Standards ComplianceChecking against the CLAUDE.md style guide:
🔍 Notable Technical DetailsMariaDB Integration:
Integration Testing:
|
🎟️ Tracking
Internal discussions. See https://bitwarden.slack.com/archives/C065AUDER62/p1759499713149319.
📔 Objective
Update the database setup and integration test instructions to include MariaDB, which I added to docker compose and the migrate script in bitwarden/server#5816. The main changes are:
Plus this PR in server, which fixes a few minor issues with the migrate script and docker compose: bitwarden/server#6420.
I also made some other updates while I was here:
[DatabaseTheory]
attribute.The current tooling here is not ideal and should be revisited. Also, using
mysql
as the key for MariaDB is confusing. However the focus of this PR is documenting what we currently have rather than changing it.⏰ Reminders before review
team
🦮 Reviewer guidelines
:+1:
) or similar for great changes:memo:
) or ℹ️ (:information_source:
) for notes or general info:question:
) for questions:thinking:
) or 💭 (:thought_balloon:
) for more open inquiry that's not quite a confirmedissue and could potentially benefit from discussion
:art:
) for suggestions / improvements:x:
) or:warning:
) for more significant problems or concerns needing attention:seedling:
) or ♻️ (:recycle:
) for future improvements or indications of technical debt:pick:
) for minor or nitpick changes