Skip to content

Conversation

@quexten
Copy link
Contributor

@quexten quexten commented Jun 16, 2025

🎟️ Tracking

https://bitwarden.atlassian.net/browse/PM-22721

📔 Objective

Init now takes an optional signing key. This is set to undefined for now, to unblock SDK updates.

SDK PR:
bitwarden/sdk-internal#207

📸 Screenshots

⏰ Reminders before review

  • Contributor guidelines followed
  • All formatters and local linters executed and passed
  • Written new unit and / or integration tests where applicable
  • Protected functional changes with optionality (feature flags)
  • Used internationalization (i18n) for all UI strings
  • CI builds passed
  • Communicated to DevOps any deployment requirements
  • Updated any necessary documentation (Confluence, contributing docs) or informed the documentation team

🦮 Reviewer guidelines

  • 👍 (:+1:) or similar for great changes
  • 📝 (:memo:) or ℹ️ (:information_source:) for notes or general info
  • ❓ (:question:) for questions
  • 🤔 (:thinking:) or 💭 (:thought_balloon:) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion
  • 🎨 (:art:) for suggestions / improvements
  • ❌ (:x:) or ⚠️ (:warning:) for more significant problems or concerns needing attention
  • 🌱 (:seedling:) or ♻️ (:recycle:) for future improvements or indications of technical debt
  • ⛏ (:pick:) for minor or nitpick changes

@quexten quexten changed the title Update sdk for breaking init change [PM-22721] Update sdk for breaking init change Jun 16, 2025
@sonarqubecloud
Copy link

@github-actions
Copy link
Contributor

Logo
Checkmarx One – Scan Summary & Details25d1a0b8-906d-4bde-ab72-e2639256e2f0

Great job, no security vulnerabilities found in this Pull Request

@codecov
Copy link

codecov bot commented Jun 16, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 36.90%. Comparing base (8505686) to head (9eabdc5).
Report is 6 commits behind head on main.

✅ All tests successful. No failed tests found.

Additional details and impacted files
@@            Coverage Diff             @@
##             main   #15212      +/-   ##
==========================================
- Coverage   36.91%   36.90%   -0.01%     
==========================================
  Files        3219     3219              
  Lines       92909    92909              
  Branches    13965    13965              
==========================================
- Hits        34297    34290       -7     
- Misses      57186    57193       +7     
  Partials     1426     1426              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@quexten quexten marked this pull request as ready for review June 16, 2025 15:24
@quexten quexten requested a review from a team as a code owner June 16, 2025 15:24
@quexten quexten requested a review from coroiu June 16, 2025 15:24
@quexten quexten merged commit 1dd7eae into main Jun 17, 2025
100 checks passed
@quexten quexten deleted the km/update-sdk-signing branch June 17, 2025 10:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants