Skip to content

Conversation

@bw-ghapp
Copy link
Contributor

@bw-ghapp bw-ghapp bot commented Dec 2, 2025

Updates the SDK version from 1.0.0-3958-7f09fd2f to com.bitwarden:sdk-android 2.0.0-4151-b444e590

Fixed

  • Added userHandle to silentlyDiscoverCredentials calls when we have a value and passed null in the other cases.
  • Wrapped the arguments privateKey , securityState, signingKey and signedPublicKey in WrappedAccountCryptographicState.
  • Added an helper method to create either a WrappedAccountCryptographicState.V1 or WrappedAccountCryptographicState.V2 depending if securityState and signingKey have value or just privateKey.

What's Changed

Raw changelog
- [PM-28748] Add RegistrationClient (#579)
- Auth/PM-28840 - SendAccessCredentials - re-order variant to fix email + OTP credential submissions (#594)
- Add Wasm feature flag to bitwarden-state (#562)
- [PM-27230] Introduce Account Cryptographic State (#563)
- [deps]: Update rust Docker tag to v1.90 (#531)
- [deps]: Update Rust to v1.91.1 (#576)
- Update API to 8a67aafbe5e01a738b479ebb82185fbc947866f8 (#578)
- PM-14922 - Move AC policy code to own crate to unblock auth login work (#600)
- Pm 28544 fix publish rust crates (#601)
- [deps]: Update Rust crate comfy-table to v7.2.1 (#447)
- [deps]: Update dtolnay/rust-toolchain digest to 0b1efab (#574)
- [deps]: Update Rust crate mockall to >=0.13.1, <0.15 (#599)
- [deps]: Update Rust crate tokio to v1.48.0 (#530)
- chore: group passkey-rs crates (#603)
- [deps]: Update Rust crate dylint_linting to v5 (#534)
- Bump bitwarden-core version to 2.0.0 (#605)
- [PM-26354] Add methods to create rotateable key sets from PRF (#494)
- fix(ci): resolve git push permission errors in version-bump (#604)
- chore: add descriptions to some releasing crates (#608)
- [PM-28135] Add crypto tracing logs (#555)
- Update passkey-rs (#606)
- [PM-29535] Update cargo-sort (#602)
- bw-auth - Add uniffi support (#609)
- ci(publish): add packages input for batched publishing (#610)
- [deps]: Update actions/checkout action to v6 (#591)
- Update API to 196e555116aba4666ae8c9cc9080291c42c1fe46 (#612)
- [PM-29846] Fix init when private key is corrupt (#614)
- [PM-29825] Add prepare_ciphers_for_bulk_share method for mobile clients (#613)

@bw-ghapp bw-ghapp bot added the automated-pr PR created by workflow or other automation label Dec 2, 2025
@bw-ghapp bw-ghapp bot requested a review from a team as a code owner December 2, 2025 16:31
@bw-ghapp bw-ghapp bot added the t:ci Change Type - Updates to automated workflows label Dec 2, 2025
@github-actions
Copy link
Contributor

github-actions bot commented Dec 2, 2025

Logo
Checkmarx One – Scan Summary & Details93afcd47-7d4c-4154-ab2e-ae7f4dad58d2

Great job! No new security vulnerabilities introduced in this pull request

@bw-ghapp bw-ghapp bot changed the title Update SDK to 1.0.0-3966-a09e691a Update SDK to 1.0.0-3967-069d7829 Dec 2, 2025
@codecov
Copy link

codecov bot commented Dec 2, 2025

Codecov Report

❌ Patch coverage is 72.38095% with 29 lines in your changes missing coverage. Please review.
✅ Project coverage is 85.49%. Comparing base (c16da50) to head (d1357d3).

Files with missing lines Patch % Lines
...twarden/data/auth/repository/AuthRepositoryImpl.kt 66.66% 6 Missing and 19 partials ⚠️
...rm/repository/AuthenticatorBridgeRepositoryImpl.kt 83.33% 0 Missing and 1 partial ⚠️
...en/data/vault/datasource/sdk/VaultSdkSourceImpl.kt 0.00% 0 Missing and 1 partial ⚠️
...twarden/data/vault/manager/VaultLockManagerImpl.kt 85.71% 0 Missing and 1 partial ⚠️
...arden/data/vault/repository/VaultRepositoryImpl.kt 85.71% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #6218      +/-   ##
==========================================
- Coverage   85.51%   85.49%   -0.02%     
==========================================
  Files         762      763       +1     
  Lines       54530    54595      +65     
  Branches     7833     7855      +22     
==========================================
+ Hits        46630    46678      +48     
- Misses       5183     5189       +6     
- Partials     2717     2728      +11     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@bw-ghapp bw-ghapp bot changed the title Update SDK to 1.0.0-3967-069d7829 Update SDK to 1.0.0-3972-7e4b2cc6 Dec 2, 2025
@bw-ghapp bw-ghapp bot changed the title Update SDK to 1.0.0-3972-7e4b2cc6 Update SDK to 1.0.0-3973-ab7ae369 Dec 3, 2025
@bw-ghapp bw-ghapp bot changed the title Update SDK to 1.0.0-3973-ab7ae369 Update SDK to 1.0.0-4001-5c178bed Dec 8, 2025
@bw-ghapp bw-ghapp bot changed the title Update SDK to 1.0.0-4001-5c178bed Update SDK to 1.0.0-4005-7840f554 Dec 8, 2025
@bw-ghapp bw-ghapp bot changed the title Update SDK to 1.0.0-4005-7840f554 Update SDK to 1.0.0-4006-0d52f617 Dec 8, 2025
@bw-ghapp bw-ghapp bot changed the title Update SDK to 1.0.0-4006-0d52f617 Update SDK to 1.0.0-4016-a8a19d3f Dec 8, 2025
@bw-ghapp bw-ghapp bot changed the title Update SDK to 1.0.0-4016-a8a19d3f Update SDK to 1.0.0-4033-1cc3a8d0 Dec 9, 2025
@bw-ghapp bw-ghapp bot changed the title Update SDK to 1.0.0-4033-1cc3a8d0 Update SDK to 1.0.0-4036-becb420b Dec 9, 2025
@bw-ghapp bw-ghapp bot changed the title Update SDK to 1.0.0-4036-becb420b Update SDK to 1.0.0-4044-14a6450a Dec 10, 2025
@bw-ghapp bw-ghapp bot changed the title Update SDK to 1.0.0-4044-14a6450a Update SDK to 1.0.0-4046-b86e0206 Dec 10, 2025
@bw-ghapp bw-ghapp bot changed the title Update SDK to 1.0.0-4046-b86e0206 Update SDK to 1.0.0-4047-26dffec3 Dec 10, 2025
@bw-ghapp bw-ghapp bot changed the title Update SDK to 1.0.0-4047-26dffec3 Update SDK to 1.0.0-4049-f0d4b0e7 Dec 10, 2025
@bw-ghapp bw-ghapp bot changed the title Update SDK to 1.0.0-4049-f0d4b0e7 Update SDK to 1.0.0-4063-ec0231c0 Dec 10, 2025
@bw-ghapp bw-ghapp bot changed the title Update SDK to 1.0.0-4063-ec0231c0 Update SDK to 2.0.0-4076-26df6719 Dec 10, 2025
@bw-ghapp bw-ghapp bot changed the title Update SDK to 2.0.0-4076-26df6719 Update SDK to 2.0.0-4078-a004d825 Dec 10, 2025
@bw-ghapp bw-ghapp bot changed the title Update SDK to 2.0.0-4078-a004d825 Update SDK to 2.0.0-4088-30879c14 Dec 11, 2025
@bw-ghapp bw-ghapp bot changed the title Update SDK to 2.0.0-4088-30879c14 Update SDK to 2.0.0-4101-fc6d3170 Dec 11, 2025
@bw-ghapp bw-ghapp bot changed the title Update SDK to 2.0.0-4101-fc6d3170 Update SDK to 2.0.0-4109-fd11c49b Dec 12, 2025
@bw-ghapp bw-ghapp bot changed the title Update SDK to 2.0.0-4109-fd11c49b Update SDK to 2.0.0-4110-bd636a4f Dec 12, 2025
@claude
Copy link
Contributor

claude bot commented Dec 16, 2025

Claude finished @bw-ghapp[bot]'s task in 2m 32s —— View job


Code Review Complete

The SDK update has been reviewed and inline comments posted.

  • Launching code review agent
  • Review complete

Verdict: APPROVE - Clean SDK migration with excellent test coverage and consistent implementation patterns.

# Conflicts:
#	app/src/test/kotlin/com/x8bit/bitwarden/data/auth/repository/AuthRepositoryTest.kt
#	app/src/test/kotlin/com/x8bit/bitwarden/data/vault/manager/VaultLockManagerTest.kt
#	app/src/test/kotlin/com/x8bit/bitwarden/data/vault/repository/VaultRepositoryTest.kt
@claude
Copy link
Contributor

claude bot commented Dec 18, 2025

Overall Assessment: APPROVE

Reviewed SDK migration from 1.0.0 to 2.0.0 covering cryptographic state wrapper changes and userHandle parameter additions across 26 files. The migration correctly implements the new WrappedAccountCryptographicState pattern and adds userHandle support to FIDO2 credential discovery. Test coverage is comprehensive with proper V1/V2 fallback handling.

See inline comment for one minor documentation clarification question.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

automated-pr PR created by workflow or other automation t:ci Change Type - Updates to automated workflows

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants