-
Notifications
You must be signed in to change notification settings - Fork 920
Update SDK to 2.0.0-4110-bd636a4f #6218
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
|
Great job! No new security vulnerabilities introduced in this pull request |
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## main #6218 +/- ##
==========================================
- Coverage 85.51% 85.49% -0.02%
==========================================
Files 762 763 +1
Lines 54530 54595 +65
Branches 7833 7855 +22
==========================================
+ Hits 46630 46678 +48
- Misses 5183 5189 +6
- Partials 2717 2728 +11 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
Claude finished @bw-ghapp[bot]'s task in 2m 32s —— View job Code Review CompleteThe SDK update has been reviewed and inline comments posted.
Verdict: APPROVE - Clean SDK migration with excellent test coverage and consistent implementation patterns. |
# Conflicts: # app/src/test/kotlin/com/x8bit/bitwarden/data/auth/repository/AuthRepositoryTest.kt # app/src/test/kotlin/com/x8bit/bitwarden/data/vault/manager/VaultLockManagerTest.kt # app/src/test/kotlin/com/x8bit/bitwarden/data/vault/repository/VaultRepositoryTest.kt
cf18f13 to
8443f38
Compare
91d616e to
58535b0
Compare
|
Overall Assessment: APPROVE Reviewed SDK migration from 1.0.0 to 2.0.0 covering cryptographic state wrapper changes and userHandle parameter additions across 26 files. The migration correctly implements the new See inline comment for one minor documentation clarification question. |

Updates the SDK version from
1.0.0-3958-7f09fd2ftocom.bitwarden:sdk-android 2.0.0-4151-b444e590Fixed
userHandletosilentlyDiscoverCredentialscalls when we have a value and passednullin the other cases.privateKey,securityState,signingKeyandsignedPublicKeyinWrappedAccountCryptographicState.WrappedAccountCryptographicState.V1orWrappedAccountCryptographicState.V2depending ifsecurityStateandsigningKeyhave value or justprivateKey.What's Changed
Raw changelog