-
-
Notifications
You must be signed in to change notification settings - Fork 225
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update total download of packages (#9164) #9165
Update total download of packages (#9164) #9165
Conversation
WalkthroughThe pull request includes updates to the Changes
Assessment against linked issues
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
🧹 Outside diff range and nitpick comments (1)
src/Websites/Platform/src/Bit.Websites.Platform.Client/Pages/AboutUsPage.razor (1)
Line range hint
49-55
: Consider improvements for maintainability and accessibility.A few suggestions to enhance this section:
- Add a "+" symbol to indicate growing numbers
- Consider fetching this number dynamically to avoid frequent updates
- Add ARIA attributes for better screen reader support
- <BitText Typography="BitTypography.H3" Gutter>5.5M</BitText> + <BitText Typography="BitTypography.H3" Gutter aria-label="5.5 million plus package downloads">5.5M+</BitText>For dynamic updates, consider creating a service that fetches the download count from NuGet's API:
public interface INuGetStatsService { Task<string> GetTotalDownloads(); }
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
📒 Files selected for processing (2)
README.md
(1 hunks)src/Websites/Platform/src/Bit.Websites.Platform.Client/Pages/AboutUsPage.razor
(1 hunks)
✅ Files skipped from review due to trivial changes (1)
- README.md
🔇 Additional comments (1)
src/Websites/Platform/src/Bit.Websites.Platform.Client/Pages/AboutUsPage.razor (1)
49-49
: LGTM! Download count successfully updated.
The update from 5.3M to 5.5M matches the PR objectives and maintains consistency with the README.md update.
closes #9164
Summary by CodeRabbit
New Features
Documentation