Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

wip: websocket connection #159

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from
Draft

wip: websocket connection #159

wants to merge 1 commit into from

Conversation

Julusian
Copy link
Member

POC to utilise bitfocus/companion@bea03af
bitfocus/companion#3101

This is intended to be an alternate connection method. By using websocket, it is easier to add on external authentication to the connection, using any reverse proxy (eg nginx/traefik)

TODO:

  • Add new config fields to define connection mode, and wsAddress
  • When setting host/port/wsAddress over the rest api, should it auto-switch to be using that protocol?
  • UI to configure this
  • Support for setting authorization header?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant