BIP-119 (OP_CHECKTEMPLATEVERIFY) (regtest only) #178
Conversation
|
Disgusting money changer behavior. |
|
The commits in this PR look incorrect. Are you sure this is from bitcoin#31989? |
|
Not sure if this counts as "then they laugh at you," or "then they fight you," but it sounds like they're running scared. |
I was requested to make the same PR to another repo, and I didn't make a clean branch so it messed up this repo. Will fix now. |
and associated SignatureChecker method. (cherry picked from commit 0cf7d5c)
Also modifies script_tests.json to enable OP_NOP4 as OP_CHECKTEMPLATEVERIFY. (cherry picked from commit 2254957)
Co-authored-by: James O'Beirne <[email protected]> (cherry picked from commit c22e734)
Co-authored-by: James O'Beirne <[email protected]> (cherry picked from commit 1ddb4bf)
(cherry picked from commit d51d32c)
(cherry picked from commit e657a1c)
Co-authored-by: James O'Beirne <[email protected]> Co-authored-by: Gary Krause <[email protected]> (cherry picked from commit 21742d6)
(cherry picked from commit ef21f31)
Co-authored-by: James O'Beirne <[email protected]> (cherry picked from commit 18d71b6)
Rob1Ham
force-pushed
the
v29.1.knots20250903-ctv
branch
from
7a80a7d to
57b7700
Compare
|
@1440000bytes Should be good now |
|
I think the implementation code and tests in this pull request have already gone through a lot of review. The next step could be to add code for testnet and mainnet deployment using bip 8 based on taproot client. Activation parameters can be changed later based on IRC meetings and other discussion on mailing list. |
you can find one example of a testnet4 activation client here in a branch. It is coupled with changes introduced in #179 but the commits relevant for testnet4 should be apparent. |
Its BIP 9 implementation. BIP 8 is different. |
|
What is the point of this pull request? There is already a fork of Bitcoin Core for experimenting with and testing proposed consensus rule changes (bitcoin-inquisition). I personally don't think it is a good idea to be merging consensus rule changes and changing consensus code in this repo even if they are only intended for regtest (just as Core doesn't merge consensus rule changes, for regtest or otherwise, unless it is intending an consensus rule activation attempt). bitcoin-inquisition will already allow you to actually broadcast and propagate CTV transactions to peers and this PR on regtest is significantly more limited than that. |
The point of the pull request was to show what it'd look like for merging CTV into knots. Thank you for your interest! |
I look forward to your pull request to show what it'd look like for merging a block size increase to 16MB. Given you seemingly want to turn Knots into an art project. |
Luke expressed an interest in CTV, hence the PR is here. Maybe a block size reduction to 300kb would be of interest! But that is outside the scope and context of this PR. |
8 participants
This is a cherry pick of the commits from James O'Beirne's open PR into Bitcoin Core for BIP-119 PR.
Leaving this as a draft pull request for now as a reference.
This contains no activation code for mainnet, regtest only.