feat: Add WalletService with createWallet Impl#61
Draft
Johnosezele wants to merge 1 commit intobitcoindevkit:mainfrom
Draft
feat: Add WalletService with createWallet Impl#61Johnosezele wants to merge 1 commit intobitcoindevkit:mainfrom
Johnosezele wants to merge 1 commit intobitcoindevkit:mainfrom
Conversation
This commit introduces the core provider state and network mapping required for wallet management, focusing on active wallet ownership and lifecycle handling. Key changes: Implement active wallet ownership and lifecycle handling in wallet_providers.dart. Add a self-dispose guard in the provider when set() receives the same wallet instance. Ensure safe disposal behavior on both clear() and provider disposal. Introduce a service-layer network mapper in wallet_network_mapper.dart. Testing: Add unit tests for ActiveWalletNotifier and WalletNetworkMapper. Include clear-path lifecycle coverage, verifying that clear() properly disposes of the wallet and resets the state to null. Verified that flutter analyze and flutter test pass successfully.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR addresses issue #5.
Notes To Reviewers
Provider/state ownership is split intentionally:
activeWalletProviderowns the BDK wallet handle.activeWalletRecordProviderowns selected persisted metadata.