Skip to content

Architecture for bdk-dart flutter reference app#58

Merged
reez merged 6 commits intobitcoindevkit:mainfrom
Johnosezele:feat/scaffold-architecture
Mar 18, 2026
Merged

Architecture for bdk-dart flutter reference app#58
reez merged 6 commits intobitcoindevkit:mainfrom
Johnosezele:feat/scaffold-architecture

Conversation

@Johnosezele
Copy link
Contributor

Architecture for the BDK Flutter reference app, skeleton needed for upcoming feature implementations.

@Johnosezele Johnosezele changed the title scaffold initial architecture for bdk-dart flutter reference app Architecture for bdk-dart flutter reference app Mar 6, 2026
@Johnosezele Johnosezele force-pushed the feat/scaffold-architecture branch from 8a728b2 to 8d28f67 Compare March 8, 2026 14:51
Copy link
Collaborator

@reez reez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a solid start for the Flutter demo scaffold!

I saw a couple things I asked questions/comments about.

Also, I don’t see any corresponding native/ or generator changes that would justify the lib/bdk.dart regeneration here, it looks like order-only UniFFI churn and should probably be dropped unless there’s a specific binding or toolchain reason for it? But let me know if there is a reason for it

@Johnosezele
Copy link
Contributor Author

Also, I don’t see any corresponding native/ or generator changes that would justify the lib/bdk.dart regeneration here, it looks like order-only UniFFI churn and should probably be dropped unless there’s a specific binding or toolchain reason for it? But let me know if there is a reason for it

Yes, its just order-only changes, I had to re-run the binding generation command to get CI to pass, I have reset bdk.dart to match main.

I have also resolved the other reviews. Thanks for taking time to review 🙏.

@Johnosezele Johnosezele requested a review from reez March 13, 2026 16:04
@j-kon
Copy link
Contributor

j-kon commented Mar 18, 2026

Went through this and I like the direction a lot.

One thing I’m thinking about is pushing it a bit further toward a “real wallet” reference rather than just a scaffold. For example, having clearer flows around receive/send, basic transaction visibility, and how sync/state changes are surfaced.

Feels like that would make it much easier for Flutter devs to actually model real apps off this instead of just using it as a starting point.

But overall, this is a really solid foundation.

Copy link
Collaborator

@reez reez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK 02ffbca

Re-reviewed, looks great, thanks for addressing everything and giving this a good foundation!

@reez reez merged commit 8ab1fa5 into bitcoindevkit:main Mar 18, 2026
5 checks passed
@Johnosezele
Copy link
Contributor Author

@j-kon

One thing I’m thinking about is pushing it a bit further toward a “real wallet” reference rather than just a scaffold

We didn't want a large PR with all these features, it would be harder to review that way, this is just an initial scaffold of what would house the other features. See chat here. Pls see the readme for intended features.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants