Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Base58chk-encoded extended keys are always 111 characters long. Amend wording of BIP accordingly #727

Closed
wants to merge 7 commits into from
Closed

Base58chk-encoded extended keys are always 111 characters long. Amend wording of BIP accordingly #727

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
c79576c
Add Trust to compatible wallets
vikmeup Sep 13, 2018
81644dd
Base58chk-encoded extended keys are always 111 characters long. Amen…
mmgen Sep 27, 2018
433283d
fix bip-0016 link 404
kaidiren Sep 28, 2018
33e040b
Merge pull request #726 from vikmeup/patch-1
luke-jr Oct 16, 2018
4b21d27
Merge pull request #728 from kaidiren/patch-1
luke-jr Oct 16, 2018
aa723fa
Base58chk-encoded extended keys are always 111 characters long. Amen…
mmgen Sep 27, 2018
7602da6
Merge branch 'bip32-patch' of https://github.com/mmgen/bips into bip3…
mmgen Oct 19, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion bip-0016/qa.mediawiki
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
This page is a Quality Assurance test plan for [[BIP 16]]. If you see a test missing, please add it.
This page is a Quality Assurance test plan for [[../bip-0016.mediawiki|BIP 16]]. If you see a test missing, please add it.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This has been fixed in 433283d.

If you can help test, please edit this page to sign-off on it.

{| class="wikitable"
Expand Down
2 changes: 1 addition & 1 deletion bip-0032.mediawiki
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -136,7 +136,7 @@ Extended public and private keys are serialized as follows:
* 32 bytes: the chain code
* 33 bytes: the public key or private key data (ser<sub>P</sub>(K) for public keys, 0x00 || ser<sub>256</sub>(k) for private keys)

This 78 byte structure can be encoded like other Bitcoin data in Base58, by first adding 32 checksum bits (derived from the double SHA-256 checksum), and then converting to the Base58 representation. This results in a Base58-encoded string of up to 112 characters. Because of the choice of the version bytes, the Base58 representation will start with "xprv" or "xpub" on mainnet, "tprv" or "tpub" on testnet.
This 78 byte structure can be encoded like other Bitcoin data in Base58, by first adding 32 checksum bits (derived from the double SHA-256 checksum), and then converting to the Base58 representation. This results in a Base58-encoded string of exactly 111 characters. Because of the choice of the version bytes, the Base58 representation will start with "xprv" or "xpub" on mainnet, "tprv" or "tpub" on testnet.

Note that the fingerprint of the parent only serves as a fast way to detect parent and child nodes in software, and software must be willing to deal with collisions. Internally, the full 160-bit identifier could be used.

Expand Down
1 change: 1 addition & 0 deletions bip-0044.mediawiki
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -274,6 +274,7 @@ is required and a pull request to the above file should be created.
* [[https://www.keepkey.com/|KeepKey]] ([[https://github.com/keepkey/|source]])
* [[https://www.ledgerwallet.com/|Ledger Wallet]] ([[https://github.com/LedgerHQ|source]])
* [[https://21.co/learn/21-lib-wallet/|21 Machine Wallet]] ([[https://github.com/21dotco|source]])
* [[https://trustwalletapp.com/|Trust Wallet]] ([[http://github.com/trustWallet/|source]])

==Reference==

Expand Down