Skip to content

BIP127: Replace network_magic with BIP44 coin_type in ProofOfReserves message #1834

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

GarmashAlex
Copy link

@GarmashAlex GarmashAlex commented Apr 24, 2025

This commit updates the ProofOfReserves message in the Protocol Buffers specification
to use BIP44 coin type IDs from SLIP-0044 instead of network magic values.

The changes include:

  • Renaming the field from 'network_magic' to 'coin_type'
  • Updating the comments to reference the SLIP-0044 registry
  • Adding examples for Bitcoin mainnet (0x80000000) and Testnet (0x80000001)

@murchandamus murchandamus changed the title Replace network_magic with BIP44 coin_type in ProofOfReserves message BIP127: Replace network_magic with BIP44 coin_type in ProofOfReserves message Apr 24, 2025
@murchandamus murchandamus added Proposed BIP modification Pending acceptance This BIP modification requires sign-off by the champion of the BIP being modified labels Apr 24, 2025
@murchandamus
Copy link
Contributor

Pinging the author: @stevenroose

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Pending acceptance This BIP modification requires sign-off by the champion of the BIP being modified Proposed BIP modification
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants