Skip to content

qml: Remove duplicate property in BlockClock #473

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jun 12, 2025
Merged

qml: Remove duplicate property in BlockClock #473

merged 1 commit into from
Jun 12, 2025

Conversation

johnny9
Copy link
Collaborator

@johnny9 johnny9 commented Jun 12, 2025

No description provided.

hebasto
hebasto approved these changes Jun 12, 2025
View reviewed changes
Copy link
Member

@hebasto hebasto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK b9a9007.

I encountered this bug in #470, where QML modules are actually compiled:

Error compiling qml file: /home/hebasto/dev/gui-qml/src/qml/BitcoinApp/Components/BlockClock.qml:21:18: error: Property duplicates alias name

I reported it offline. This PR fixes this issue.

@hebasto hebasto merged commit 07093a1 into bitcoin-core:main Jun 12, 2025
9 checks passed
@hebasto hebasto mentioned this pull request Jun 12, 2025
Draft
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hebasto hebasto hebasto approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@johnny9 @hebasto