Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mini Paint #453

Merged
merged 4 commits into from
Jan 2, 2025
Merged

Mini Paint #453

merged 4 commits into from
Jan 2, 2025

Conversation

SitaGanesh
Copy link
Contributor

Description

I have added a mini-paint folder with HTML, CSS, and JS files. which creates a webpage having the paint application with features like selecting a color, brush size, and eraser, clearing the board completely, downloading the drawn image in PNG or JPG format.
There is no dependency.

Fixed #194

Type of change

  • New feature (non-breaking change which adds functionality)

Checklist:

  • My code follows the style guidelines(Clean Code) of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have created a helpful and easy to understand README.md
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added screenshots(if any) that prove my fix is effective or that my feature works

…ation with features like selecting a color, brush size, eraser, clearing the board completely, download the drawn image in PNG or JPG format
@SitaGanesh
Copy link
Contributor Author

Dear sir @bislara!, as the adding feature #194 Mini Paint is done. Now you are good to merge and close this issue.

Pencil button functionality is added and a `not-allowed` cursor style for the eraser button for a better UI.
@github-actions github-actions bot requested a review from bislara January 2, 2025 13:27
Copy link
Owner

@bislara bislara left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perfect all looks good. It would be better though if u put the pencil button in the beginning of the buttons list.
Good job @SitaGanesh. I am happy to approve now.

As a further improvement if possible, I would suggest to add the feature of fill color.

Updated the pencil button at the beginning of the buttons
@github-actions github-actions bot requested a review from bislara January 2, 2025 17:08
@bislara bislara merged commit 3d0f9e0 into bislara:master Jan 2, 2025
3 checks passed
Copy link

github-actions bot commented Jan 2, 2025

Thanks very much for contributing! Your pull request has been merged 🎉 Hoping for more contribution from you in future.
Do give a ⭐ if you like this project

Happy hacking and Learning ✌🤟
Thanks again! ✨

@bislara
Copy link
Owner

bislara commented Jan 2, 2025

@all-contributors please add @SitaGanesh for code, doc

Copy link
Contributor

@bislara

I've put up a pull request to add @SitaGanesh! 🎉

@SitaGanesh
Copy link
Contributor Author

Thankyou Sir @bislara , and team code-n-stitch. Since this is my first contribution and I feel very happy to be in this part of the code.

I don't know what to do further, after being a contributor, I guess any help!

Coming to the mini-paint issue, I was working on implementing the color-filling-functionality. I was not able to catch what actually it is made of, which involves some sort of algorithm like flood fill and canvas manipulation even though I will be trying to do this taking into a challenge.

@bislara
Copy link
Owner

bislara commented Jan 3, 2025

@SitaGanesh further you can pick up any existing issues in the repo or u can create a new issue which you think would be a good addition and work on it.

In the paint issue, give it a try, understand the underlying functionalities of the canvas and how it can be used to fill color using some algorithm.
You can start first with applying color to the pencil that you have added.

@SitaGanesh
Copy link
Contributor Author

Sure sir @bislara, I think it would be good if i creating a new issue and work on it.

I will figure it out what sort of algorithm it's build of it. And I will try to take small steps to achieve this task.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Mini Paint
2 participants