Support hardlink detection on Windows nightly #22
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
On nightly, there are function that are essentially Windows counterpart to ino and dev, file_index and volume_serial_number. The problem is, on directory walking, as opposed to getting metadata from a file directly, they return None, so I had to change logic of the inner loop as well as check_inode signature.
Next trouble was checking if nightly build or not. I had to use build.rs script to get this info.
Checked Windows and WSL build, all seems to work as expected, hardlinks are skipped on nightly build and considered dupes on stable.