feat: callbacks #46
Open
feat: callbacks #46
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
Author
|
Hey @birkenfeld, sorry in advance, this is another big one. I'm fairly confident that the new tests give good enough coverage, but it's always good to have a second set of eyes. |
|
I think a small update to the notify example, showing the difference to thew raw notify approach, would be nice for discoverability of this new feature, too. |
cartercanedy
force-pushed
the
support-notification-callbacks
branch
from
8e11ea6 to
c9a28ae
Compare
MGRatEJOT
reviewed
Sep 23, 2025
MGRatEJOT
reviewed
Sep 23, 2025
MGRatEJOT
reviewed
Sep 23, 2025
cartercanedy
force-pushed
the
support-notification-callbacks
branch
from
15639bf to
5546c3e
Compare
* don't panic on failure to resolve IP address * cover additional Error variant in Clone impl * fmt
…tching notifications
cartercanedy
force-pushed
the
support-notification-callbacks
branch
from
5546c3e to
b4bc310
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This makes it much nicer to deal with notifications. Callbacks are filtered, so consumers wouldn't have to do any of their own filtering in application code. Otherwise, it's just a nice-to-have :)