Open
Conversation
github-actions
bot
added
documentation
Collaborator
E2E Test ResultsDACCS-iac Pipeline ResultsBuild URL : http://daccs-jenkins.crim.ca:80/job/DACCS-iac-birdhouse/3986/Result ❌ FAILUREBIRDHOUSE_DEPLOY_BRANCH : magpie-networking DACCS_IAC_BRANCH : master DACCS_CONFIGS_BRANCH : master PAVICS_E2E_WORKFLOW_TESTS_BRANCH : master PAVICS_SDI_BRANCH : master DESTROY_INFRA_ON_EXIT : true PAVICS_HOST : https://host-140-91.rdext.crim.ca PAVICS-e2e-workflow-tests Pipeline ResultsTests URL : http://daccs-jenkins.crim.ca:80/job/PAVICS-e2e-workflow-tests/job/master/618/NOTEBOOK TEST RESULTS |
fmigneault
reviewed
Jan 22, 2026
Comment on lines
+44
to
+45
| export MAGPIE_NETWORK_PEM_FILES=key.pem # These files must be relative paths from the MAGPIE_NETWORK_PEM_DIR directory | ||
| export MAGPIE_NETWORK_PEM_PASSWORDS= |
Member
There was a problem hiding this comment.
Looks like the must be : separated from below parsing. I assume any path is remapped as is with the same hierarchy? Maybe a small comment/example can help for this.
For the passwords case, I assume that "no-password" files would need ::<pwd>: for example if the 3rd out of 4 files provided needs a password? Similarly, an example comment to help users configure it correctly.
| # https://pavics-magpie.readthedocs.io/en/latest/configuration.html#network-mode-settings | ||
| export MAGPIE_NETWORK_PEM_DIR='${BIRDHOUSE_DATA_PERSIST_ROOT}/magpie_pem' | ||
| export MAGPIE_NETWORK_ENABLED=false # Note: by default network mode is off (false) | ||
| export MAGPIE_NETWORK_INSTANCE_NAME= # Note: this must be a unique name in the network so no default is set |
Member
There was a problem hiding this comment.
Could we do something, like a pre-compose... file, that verifies that it is set if enabled, logs an error & aborts if detected?
| [//]: # (list changes here, using '-' for each new entry, remove this when items are added) | ||
| ## Changes | ||
|
|
||
| - Update `magpie` to version 5.0.0 |
Member
There was a problem hiding this comment.
Since it is a major, a note is warranted to indicate that it does not impact existing DB/migration stuff. It only adds extra tables if network mode is enabled, but fully backward compatible.
Expecting @tlvu will have this question 😉
Collaborator
There was a problem hiding this comment.
It only adds extra tables if network mode is enabled, but fully backward compatible.
Confirmed fully backward compatible, only DB migration I see:
[alembic.runtime.migration] Running upgrade 5e5acc33adce -> 2cfe144538e8, Add Network_Tokens Table`)
Now that I have a test machine with Magpie 5, how can I try this network mode with you guys?
Collaborator
There was a problem hiding this comment.
I guess I can spin up another PAVICS instance and try network mode with myself but I don't enough juice :(
I only have 2 dev VM and the other VM is stuck testing the Jupyter config refactoring :(
Member
There was a problem hiding this comment.
Is your instance accessible from the web?
We'll have to exchange PEM keys and register each other's instances accordingly.
Collaborator
There was a problem hiding this comment.
Is your instance accessible from the web?
Yes
We'll have to exchange PEM keys and register each other's instances accordingly.
Ready when you guys are ready.
Collaborator
Author
There was a problem hiding this comment.
My test instances aren't available outside my network. If you want to test this before approving this PR I can send you a minimal working example that should be testable on your VMs. If you give me a few days I can send you that separately so you can test it out yourself.
Collaborator
There was a problem hiding this comment.
Since this network mode is not enabled by default, I assume there are no risk of regressions. I was simply curious how this network mode actually works and whether the documentation is complete. I can approve as-is and we can test later if that is more convenient for you guys.
Collaborator
Author
There was a problem hiding this comment.
No worries. If you want to test it out a bit I've added a proposed example here Ouranosinc/Magpie#648 that will let you test out the network mode locally.
Collaborator
E2E Test ResultsDACCS-iac Pipeline ResultsBuild URL : http://daccs-jenkins.crim.ca:80/job/DACCS-iac-birdhouse/3989/Result ❌ FAILUREBIRDHOUSE_DEPLOY_BRANCH : magpie-networking DACCS_IAC_BRANCH : master DACCS_CONFIGS_BRANCH : master PAVICS_E2E_WORKFLOW_TESTS_BRANCH : master PAVICS_SDI_BRANCH : master DESTROY_INFRA_ON_EXIT : true PAVICS_HOST : https://host-140-91.rdext.crim.ca PAVICS-e2e-workflow-tests Pipeline ResultsTests URL : http://daccs-jenkins.crim.ca:80/job/PAVICS-e2e-workflow-tests/job/master/620/NOTEBOOK TEST RESULTS |
fmigneault
approved these changes
Jan 23, 2026
Collaborator
E2E Test ResultsDACCS-iac Pipeline ResultsBuild URL : http://daccs-jenkins.crim.ca:80/job/DACCS-iac-birdhouse/4000/Result 🆘 ABORTEDBIRDHOUSE_DEPLOY_BRANCH : magpie-networking DACCS_IAC_BRANCH : master DACCS_CONFIGS_BRANCH : master PAVICS_E2E_WORKFLOW_TESTS_BRANCH : master PAVICS_SDI_BRANCH : master DESTROY_INFRA_ON_EXIT : true PAVICS_HOST : https://host-140-133.rdext.crim.ca
|
Member
|
Version https://github.com/Ouranosinc/Magpie/tree/5.0.1 to be considered. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Overview
This update to Magpie introduces network mode.
This is disabled by default to ensure backwards compatibility but can be enabled by setting
MAGPIE_NETWORK_ENABLED=truein your local environment file.Note that enabling network mode also requires setting
MAGPIE_NETWORK_INSTANCE_NAMEto a unique name within the network.This change also introduces the ability to set all configuration options for Magpie's network mode as environment variables in the local environment file.
Note that all of these configuration options will be ignored if
MAGPIE_NETWORK_ENABLEDisfalse.Changes
Non-breaking changes
Breaking changes
Related Issue / Discussion
Additional Information
CI Operations
birdhouse_daccs_configs_branch: master
birdhouse_skip_ci: false