Skip to content

Parse constants.ini#14

Open
san-e wants to merge 3 commits into
biqqles:masterfrom
san-e:constants
Open

Parse constants.ini#14
san-e wants to merge 3 commits into
biqqles:masterfrom
san-e:constants

Conversation

@san-e
Copy link
Copy Markdown
Contributor

@san-e san-e commented Nov 6, 2022

I wasn't exactly sure where to put this, so I added the function to interface.py, let me know if you'd like it somewhere else

@biqqles
Copy link
Copy Markdown
Owner

biqqles commented Nov 17, 2022

Nice, you used paths.inis! I don't think it makes sense in interface.py, as you say, but need to think about it as the alternatives aren't great

  • routines.py is kind of a dumping ground for random functions, but everything there constructs an EntitySet
  • __init__.py might make sense but seems a bit weird to put a function there

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants