Command history save and load #304
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
amnona
commented
Jun 24, 2024
amnona
commented
- Add a command history file to the Experiment save and load, so user can view the commands used to reach the saved Experiment.
- Add to changelog
- Bump version
command_history_save_load
|
@RNAer can you go over/merge? |
RNAer
reviewed
Jul 4, 2024
| @@ -345,6 +345,7 @@ def _read_metadata(ids, f, kwargs): | |||
|
|
|||
| @ds.get_sectionsf('io.read') | |||
| def read(data_file, sample_metadata_file=None, feature_metadata_file=None, | |||
| call_history_file=None, | |||
There was a problem hiding this comment.
why do we need it in read()? it seems a separate logic from read(). let's not make the already complicated function api even more complicated?
There was a problem hiding this comment.
I think important since otherwise you get partial/missing history
We can do that if call_history is True (which we set as default instead of None), can try to automatically load the call history based on the data_file filename (as created in the save() ) if it exists.
I am afraid if we do it a separate function, people will be lazy/not know about it and then they lose the history once they load a saved file and continue working
What to you think?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.