Skip to content
This repository was archived by the owner on Feb 22, 2024. It is now read-only.

Fix build error (non optimized svg) #7243

Closed
wants to merge 2 commits into from
Closed

Fix build error (non optimized svg) #7243

wants to merge 2 commits into from

Conversation

thibault-deriv
Copy link
Contributor

@thibault-deriv thibault-deriv commented Sep 22, 2022

Changes

  • There is a svg that makes the CircleCI fail on PR build (e.g. #7227)

error-ci

The error

error

I was unable to optimize via svgo (broken svg) so I used inkscape.

I haven't checked the result (I don't know where the sprites are used).

@vercel
Copy link

vercel bot commented Sep 22, 2022

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated
binary-static ✅ Ready (Inspect) Visit Preview Sep 23, 2022 at 6:48AM (UTC)

@github-actions
Copy link

github-actions bot commented Sep 22, 2022

A production App ID was automatically generated for this PR. (log)

Click here to copy & paste above information.
- **PR**: [https://github.com/binary-com/binary-static/pull/7243](https://github.com/binary-com/binary-static/pull/7243)
- **URLs**:
    - **w/ App ID + Server**: https://binary-static-git-fork-thibault-deriv-fixsvg.binary.sx/en/logged_inws.html?qa_server=frontend.binaryws.com&app_id=31135
    - **Original**: https://binary-static-git-fork-thibault-deriv-fixsvg.binary.sx/en/logged_inws.html
- **App ID**: `31135`

@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.4% 0.4% Duplication

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant