LabelBOT #1012
Open
LabelBOT #1012
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mzur
requested changes
Dec 18, 2024
There was a problem hiding this comment.
Please don't implement all the logic as helper methods. Since the logic is used only in the single controller (for now), implement it as (protected) controller methods there.
Also please us camelCase for variable names.
Finally, please fix the failing checks (except the test-current check which fails because biigle/largo is not there). The lint checks can be run locally with composer lint and composer fix.
mzur
reviewed
Dec 20, 2024
mzur
reviewed
Jan 6, 2025
mzur
reviewed
Jan 6, 2025
These are used by the new biigle/metrics module.
Long blocking migrations are unusual so I chose the console command instead. LabelBOT will also work without the index, only slower. Also I added CONCURRENTLY so the create index operation does not create a write lock. Finally, the index for video annotations is already created, too, in preparation for LabelBOT in the video annotation tool.
Unchecked, listeners for some key combinations (e.g. Esc) would be called twice.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TODO v3 (#988)
Backend
Frontend
If computing the feature vector client-side takes a significant amount of time, we could try to compute vectors at fixed intervals already while the user draws the annotation. If the final annotation is reasonably contained in the vector bounding box that was previously computed, immediately send the vector to the backend instead of computing it only after the annotation was finished.Implement the ONNX inference as a web worker so the UI does not block while inference is runningWhen the random/regular sampling mode is active, LabelBOT should immediately suggest a label for the currently active point. When the label is confirmed with Enter or a click, the annotation mode advances to the next point. The LabelBOT timeout is disabled here, i.e. users always have to confirm the chosen labels. The suggested label for the next point could even be prefetched while the user is still looking at the current point.Point to shape conversion with SAM or PTP.