Update workflow-preset provider boundaries - #37
Conversation
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 4b21f78d87
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| "BDD", | ||
| "UIF-", | ||
| "Visual Item ID", | ||
| "Requirement Status", |
There was a problem hiding this comment.
For visual handoffs, _handoff_requires_traceable_validation_evidence() is true, but this marker list lets _receipt_references_traceable_validation_evidence() accept any single phrase; for example, validation_evidence: ["Requirement Status Required"] passes with completed task IDs even though speckit.implement.md requires the relevant Visual Item ID, status, and evidence refs. This allows Core to mark visual work complete without traceable visual evidence, so the visual path should require the identifier plus an actual evidence reference rather than treating Requirement Status alone as sufficient.
Useful? React with 👍 / 👎.
| self.assertEqual("workflow-preset", data["preset"]["id"]) | ||
| self.assertEqual("Workflow Preset", data["preset"]["name"]) | ||
| self.assertEqual("1.3.11", data["preset"]["version"]) | ||
| self.assertEqual("1.3.10", data["preset"]["version"]) |
There was a problem hiding this comment.
This assertion now expects 1.3.10, but the bundled manifest and both catalog entries in this commit still advertise 1.3.11. In an environment with the preset test dependencies installed, the documented python3 -m unittest tests/test_preset_contract.py fails in the manifest contract before validating the provider-boundary changes; keep this assertion on 1.3.11 unless the manifest/catalogs are intentionally downgraded.
Useful? React with 👍 / 👎.
| ```text | ||
| /speckit.specify <Figma URL> | ||
| /speckit.intake.visual-design <source> | ||
| /speckit.intake.html-ssot <source-or-intake-dir> |
There was a problem hiding this comment.
The intake extension does not register /speckit.intake.html-ssot; the command provided in extensions/intake/extension.yml is speckit.intake.figma2htmlssot. Users following this new workflow-preset example will hit an unknown command when trying HTML SSOT capture, so the example should use the registered command name.
Useful? React with 👍 / 👎.
1 participant
Summary
presets/workflow-presetfrombigsmartben/spec-kit-workflow-preset@deb60d8.Validation
python.exe -m pytest tests/test_presets.py -k workflow_presetpython.exe -m pytest tests/test_presets.py -k community_smoke_checks_wheel_assetsrg "Figma|figma" presets/workflow-preset .github/workflows/workflow-preset-integration.yml .github/workflows/community-smoke.ymlreturned no matchesNotes
A full local Windows run of
tests/test_presets.pyhad unrelated failures in catalog sha mismatch and Kimi skill tests; the workflow-preset and touched smoke-contract tests passed locally.