Update workflow-preset to v1.3.7 - #13
Conversation
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
馃挕 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 9f4679cad9
鈩癸笍 About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 馃憤.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
|
|
||
| for index, finding in enumerate(mutation_findings): | ||
| _validate_data_side_effect_finding(finding, index=index) | ||
| for finding in data_side_effect_review.get("mutation_findings", []): |
There was a problem hiding this comment.
When validate_receipt_contract() is called directly, as validate_implement_contract() does, a code-review receipt can now omit both runtime_data_writes_found and mutation_findings and still pass because this lookup defaults to an empty list. That contradicts the receipt schema and /speckit.implement command requirement for data-side-effect review fields, so malformed approved review receipts can be accepted without recording whether runtime data writes were reviewed.
Useful? React with 馃憤聽/ 馃憥.
| workflow_path = REPO_ROOT / ".github" / "workflows" / "ci.yml" | ||
| if not workflow_path.exists(): | ||
| self.skipTest("GitHub Actions workflow is not bundled in spec-kit checkout") | ||
| self.assertTrue(workflow_path.exists()) |
There was a problem hiding this comment.
In the bundled spec-kit checkout, presets/workflow-preset/.github/workflows/ci.yml and preset-artifact.yml are not included with the preset, which is why the previous test skipped when the files were absent. Changing this to a hard assertion makes python3 -m unittest tests/test_preset_contract.py fail immediately for the bundled preset suite unless those workflow files are also bundled; the same issue repeats for preset-artifact.yml below.
Useful? React with 馃憤聽/ 馃憥.
|
Closing as superseded by workflow-preset v1.3.8 in #14 and the latest community release bigsmartben-v0.8.14-community.5. |
1 participant
Summary
Test Plan