Update workflow-preset to v1.3.5 - #11
Conversation
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
馃挕 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 3b4a1f16af
鈩癸笍 About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 馃憤.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
|
|
||
| for index, finding in enumerate(mutation_findings): | ||
| _validate_data_side_effect_finding(finding, index=index) | ||
| for finding in data_side_effect_review.get("mutation_findings", []): |
There was a problem hiding this comment.
When a code-review receipt's data_side_effect_review omits mutation_findings or runtime_data_writes_found, this .get(..., []) path now treats the missing review as an empty list and accepts the receipt, even though the receipt schema and /speckit.implement command still require those fields. That lets validate_receipt_contract()/validate_implement_contract() approve code-review receipts without the required data side-effect evidence, and malformed mutation findings are no longer rejected.
Useful? React with 馃憤聽/ 馃憥.
| workflow_path = REPO_ROOT / ".github" / "workflows" / "ci.yml" | ||
| if not workflow_path.exists(): | ||
| self.skipTest("GitHub Actions workflow is not bundled in spec-kit checkout") | ||
| self.assertTrue(workflow_path.exists()) |
There was a problem hiding this comment.
In the bundled preset checkout, REPO_ROOT is presets/workflow-preset, and that tree does not contain .github/workflows/ci.yml; the previous skip handled this case. With the unconditional assertion, running the documented focused suite (python3 -m unittest tests/test_preset_contract.py) from this preset fails before checking the workflow contract unless those workflow files are bundled into the preset tree.
Useful? React with 馃憤聽/ 馃憥.
| @@ -0,0 +1,6 @@ | |||
| #!/home/runner/work/spec-kit-workflow-preset/spec-kit-workflow-preset/.venv-specify-smoke/bin/python3 | |||
There was a problem hiding this comment.
This newly added virtualenv is under presets/workflow-preset, which pyproject.toml force-includes wholesale in wheels and PresetManager.install_from_directory() copies wholesale into projects. As a result, every bundled/local install carries GitHub-runner-specific venv files like this shebang pointing at /home/runner/..., leaving broken executables and unrelated test output inside installed presets.
Useful? React with 馃憤聽/ 馃憥.
1 participant
Summary
Test Plan