support full extended swap styles in htmx oob swaps #97
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MichaelWest22
changed the title
|
should resolve #40 hopefully |
|
Hmm... this looks to me like something that should be fixed in htmx, rather than worked-around in Idiomorph. @1cg what do you think about resolving it via bigskysoftware/htmx#2308 ? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently oob swaps in htmx are not supported with idiomorph if you want to do a inner style morph as they include a : which is a seperator in hx-swap-oob. So to support this i've allowed : to be replaced with ;; in the swap style so it can also be used for supporting extended config inside the swap style as well.
For example here is a now supported extended swap with hx-swap-oob: