Add coverage for untested code paths and features; rm test noise #80
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A lot of the tricky code around head handling and value property handling was untested, so this PR brings our coverage way up, giving me much more confidence to try to add twoPass without regressions. Now we're only missing coverage for very minor codepaths.
I've also gone ahead and removed a lot of noise from the test output. This removal came in two flavors:
test/core
had extra console logs diffing the actual and expected output. This seems unnecessary given that the test itself performs and displays this diff, and also noticing that many of them were out of date and no longer reflected the actual intent of the test. Delete!// debugging output
.npm test
is nice and pretty now!