Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add coverage for untested code paths and features; rm test noise #80

Merged
merged 3 commits into from
Dec 20, 2024

Conversation

botandrose
Copy link
Collaborator

@botandrose botandrose commented Dec 20, 2024

A lot of the tricky code around head handling and value property handling was untested, so this PR brings our coverage way up, giving me much more confidence to try to add twoPass without regressions. Now we're only missing coverage for very minor codepaths.

I've also gone ahead and removed a lot of noise from the test output. This removal came in two flavors:

  1. Most of the tests in test/core had extra console logs diffing the actual and expected output. This seems unnecessary given that the test itself performs and displays this diff, and also noticing that many of them were out of date and no longer reflected the actual intent of the test. Delete!
  2. Other tests were dumping info that might be useful for debugging the test if something was wrong, but not useful while the tests are passing. I've commented these lines out and given them a header of // debugging output.

npm test is nice and pretty now!

image

@botandrose botandrose changed the title Add coverage for untested code paths and features Add coverage for untested code paths and features; rm test noise Dec 20, 2024
@1cg 1cg merged commit 3ea28d4 into bigskysoftware:main Dec 20, 2024
2 checks passed
@botandrose botandrose deleted the test-coverage branch December 20, 2024 21:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants