fix extraneous 'remove' attribute hook call.

bigskysoftware · Dec 17, 2024 · da7ade6 · da7ade6
1 parent 4721e95
commit da7ade6
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 5 deletions.
diff --git a/src/idiomorph.js b/src/idiomorph.js
@@ -439,10 +439,10 @@ var Idiomorph = (function () {
                 // iterate backwards to avoid skipping over items when a delete occurs
                 for (let i = toAttributes.length - 1; 0 <= i; i--) {
                     const toAttribute = toAttributes[i];
-                    if (ignoreAttribute(toAttribute.name, toEl, 'remove', ctx)) {
-                        continue;
-                    }
                     if (!fromEl.hasAttribute(toAttribute.name)) {
+                        if (ignoreAttribute(toAttribute.name, toEl, 'remove', ctx)) {
+                            continue;
+                        }
                         toEl.removeAttribute(toAttribute.name);
                     }
                 }

diff --git a/test/hooks.js b/test/hooks.js
@@ -115,7 +115,7 @@ describe("lifecycle hooks", function(){
         calls.should.eql(["<li>B</li>"]);
     });
 
-    it.skip('calls beforeAttributeUpdated when an attribute is added', function(){
+    it('calls beforeAttributeUpdated when an attribute is added', function(){
         let calls = [];
         let initial = make("<a></a>");
         Idiomorph.morph(initial, `<a href="#"></a>`, { callbacks: {
@@ -127,7 +127,7 @@ describe("lifecycle hooks", function(){
         calls.should.eql([["href", `<a></a>`, "update"]]);
     });
 
-    it.skip('calls beforeAttributeUpdated when an attribute is updated', function(){
+    it('calls beforeAttributeUpdated when an attribute is updated', function(){
         let calls = [];
         let initial = make(`<a href="a"></a>`);
         Idiomorph.morph(initial, `<a href="b"></a>`, { callbacks: {