Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix hx-vals/hx-vars encoding along json-enc #57

Merged
merged 2 commits into from
Jul 22, 2024
Merged

Fix hx-vals/hx-vars encoding along json-enc #57

merged 2 commits into from
Jul 22, 2024

Conversation

Telroshan
Copy link
Collaborator

Fixes #56

  • Current behavior can be observed on this JSFiddle, notice the incorrect payload
    image

  • Behavior with this PR's fix can be observed on this JSFiddle, notice the now correct payload
    image

@Telroshan Telroshan added the bug Something isn't working label Jul 21, 2024
@netlify Netlify
Copy link

netlify bot commented Jul 21, 2024 •
edited
Loading

✅ Deploy Preview for htmx-extensions canceled.

Name Link
🔨 Latest commit 5511d3c
🔍 Latest deploy log https://app.netlify.com/sites/htmx-extensions/deploys/669e059581915f0008c67038

@Telroshan Telroshan mentioned this pull request Jul 21, 2024
Closed
@Telroshan Telroshan changed the title Fix hx-vals/hx-vars encoding along json-enc #2735 Fix hx-vals/hx-vars encoding along json-enc #56 Jul 21, 2024
@Telroshan Telroshan changed the title Fix hx-vals/hx-vars encoding along json-enc #56 Fix hx-vals/hx-vars encoding along json-enc Jul 21, 2024
sameer-dudeja
sameer-dudeja approved these changes Jul 21, 2024
View reviewed changes
Copy link
Contributor

@sameer-dudeja sameer-dudeja left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall Looks Great.

src/json-enc/json-enc.js Show resolved Hide resolved
src/json-enc/json-enc.js Outdated Show resolved Hide resolved
@Telroshan Telroshan merged commit 594a21a into main Jul 22, 2024
5 checks passed
@Telroshan Telroshan deleted the fix-json-vals branch July 22, 2024 07:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sameer-dudeja sameer-dudeja sameer-dudeja approved these changes

Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

json-enc incorrectly encodes hx-vals in v2.0.1
2 participants
@Telroshan @sameer-dudeja