-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Duct insulation air film #2
base: master
Are you sure you want to change the base?
Conversation
…tion R-value variables for both supply and return ducts.
@nathancoliver, can you make this DRYer? Since the air film is calculated, it probably shouldn't be an input parameter in the template. |
@nealkruis do you think I could change the .pxv files so that the duct air film is equal to 6, and change the base.pxt file to include an if-else statement, where the if statement uses the default air film, and the else statement uses the equation to calculate the air film? |
@nealkruis I updated the branch per our conversation. The changes should be self-explanatory, but for our records, here is an overview of the changes.
|
base.pxt
Outdated
def calculate_duct_air_film_r_value(duct_insulation_r_value,duct_type) | ||
if duct_type == "SUPPLY" | ||
return 2.2438 - 0.4381 * duct_insulation_r_value | ||
elsif duct_type == "RETURN" | ||
return 2.0388 - 0.2947 * duct_insulation_r_value | ||
end | ||
end |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Did you test what happens if the air film is less than 1?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I performed some tests, and it appears that negative air films close to zero produce unusual and unexpected heating and cooling energy use results. Other air film values, including positive numbers between 0 and 1 and negative numbers less than 1, do not produce strange results.
@nealkruis I moved the air film calculation when the duct is uninsulated into the 'calculate air film r-value' function. |
I would like to start a conversation about updating uninsulated and insulated duct supply and return R-values, per Std 301 changes. Below is a summary of the changes.
base.pxt
<case name>.pxv
Let me know if there is anything that should be updated.