Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Duct insulation air film #2

Open
wants to merge 7 commits into
base: master
Choose a base branch
from
Open

Conversation

nathancoliver
Copy link
Member

I would like to start a conversation about updating uninsulated and insulated duct supply and return R-values, per Std 301 changes. Below is a summary of the changes.

base.pxt

  • Changed default air film R-values from 1.5 to 1.7. This defines uninsulated duct effective R-values.
  • Created air film and insulation R-value variables for supply and return ducts.

<case name>.pxv

  • Set insulation R-values to 0.
  • Set air film R-values equal to Std 301 effective supply and return duct insulation R-values.

Let me know if there is anything that should be updated.

@nathancoliver nathancoliver requested a review from nealkruis July 6, 2023 21:47
@nealkruis
Copy link
Member

@nathancoliver, can you make this DRYer? Since the air film is calculated, it probably shouldn't be an input parameter in the template.

@nathancoliver
Copy link
Member Author

nathancoliver commented Jul 10, 2023

@nealkruis do you think I could change the .pxv files so that the duct air film is equal to 6, and change the base.pxt file to include an if-else statement, where the if statement uses the default air film, and the else statement uses the equation to calculate the air film?

@nathancoliver
Copy link
Member Author

@nealkruis I updated the branch per our conversation. The changes should be self-explanatory, but for our records, here is an overview of the changes.

  • Removed duct air film r-values from .pxv files.
  • Updated duct insulation r-values to reflect the nominal insulation r-value.
  • Added a definition in base.pxt to calculate an air film r-value from the nominal duct insulation that will result in an effective insulation r-value as specified in Standard 301.
  • The definition is only called when the duct is insulated.

base.pxt Outdated
Comment on lines 80 to 86
def calculate_duct_air_film_r_value(duct_insulation_r_value,duct_type)
if duct_type == "SUPPLY"
return 2.2438 - 0.4381 * duct_insulation_r_value
elsif duct_type == "RETURN"
return 2.0388 - 0.2947 * duct_insulation_r_value
end
end
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Did you test what happens if the air film is less than 1?

Copy link
Member Author

@nathancoliver nathancoliver Jul 11, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I performed some tests, and it appears that negative air films close to zero produce unusual and unexpected heating and cooling energy use results. Other air film values, including positive numbers between 0 and 1 and negative numbers less than 1, do not produce strange results.

@nathancoliver
Copy link
Member Author

@nealkruis I moved the air film calculation when the duct is uninsulated into the 'calculate air film r-value' function.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants